<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21959">View Revision</a></tr></table><br /><div><div><p>+1 for the included unittest.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21959#inline-123759">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdeplatformfiledialoghelper.cpp:80</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">static</span> <span class="n">QString</span> <span class="n">kde2QtFilter</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QStringList</span> <span style="color: #aa2211">&</span><span class="n">list</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">kde</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">static</span> <span class="n">QString</span> <span class="n">kde2QtFilter</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QStringList</span> <span style="color: #aa2211">&</span><span class="n">list</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">kde<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QString</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span class="n"><span class="bright">filterText</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">(hehe I keep thinking this is about KDE-2 stuff... what a dinosaur I am)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21959#inline-123760">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdeplatformfiledialoghelper.cpp:90</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">(</span><span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">')'</span><span class="p">)</span> <span style="color: #aa2211">==</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">)[</span><span class="n">pos</span> <span style="color: #aa2211">+</span> <span class="n">kde</span><span class="p">.</span><span class="n">length</span><span class="p">()]</span> <span style="color: #aa2211">||</span> <span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">' '</span><span class="p">)</span> <span style="color: #aa2211">==</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">)[</span><span class="n">pos</span> <span style="color: #aa2211">+</span> <span class="n">kde</span><span class="p">.</span><span class="n">length</span><span class="p">()])<span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">(</span><span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">')'</span><span class="p">)</span> <span style="color: #aa2211">==</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">)[</span><span class="n">pos</span> <span style="color: #aa2211">+</span> <span class="n">kde</span><span class="p">.</span><span class="n">length</span><span class="p">()]</span> <span style="color: #aa2211">||</span> <span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">' '</span><span class="p">)</span> <span style="color: #aa2211">==</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">)[</span><span class="n">pos</span> <span style="color: #aa2211">+</span> <span class="n">kde</span><span class="p">.</span><span class="n">length</span><span class="p">()])<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">(</span><span class="n">filterText</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">()</span> <span style="color: #aa2211">||</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">filterText</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">it</span><span style="color: #aa2211">-></span><span class="n">startsWith</span><span class="p">(</span><span class="n">filterText</span><span class="p">))))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span> <span style="color: #aa2211">*</span><span class="n">it</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the <tt style="background: #ebebeb; font-size: 13px;">!filterText.isEmpty() &&</tt> part is redundant.<br />
In this part of the condition, we know it's not empty, otherwise shortcut evaluation happened after isEmpty returns true.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">blue or (not blue and green)</pre></div>
<p style="padding: 0; margin: 8px;">is really the same as</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">blue or green</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R135 Integration for Qt applications in Plasma</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21959">https://phabricator.kde.org/D21959</a></div></div><br /><div><strong>To: </strong>hoffmannrobert, Frameworks, apol, dfaure<br /><strong>Cc: </strong>michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>