<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21907">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21907#inline-123339">View Inline</a><span style="color: #4b4d51; font-weight: bold;">meven</span> wrote in <span style="color: #4b4d51; font-weight: bold;">knewfilemenu.cpp:1071</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">What about Windows ? maybe use QDir::separator() ?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">read the docu for QDir::separator() , you seldom ever want to use it.</p>
<p style="padding: 0; margin: 8px;"><a href="https://agateau.com/2015/qdir-separator-considered-harmful/" class="remarkup-link" target="_blank" rel="noreferrer">https://agateau.com/2015/qdir-separator-considered-harmful/</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21907">https://phabricator.kde.org/D21907</a></div></div><br /><div><strong>To: </strong>ngraham, VDG, Frameworks, shubham<br /><strong>Cc: </strong>aacid, meven, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns<br /></div>