<table><tr><td style="">leinir updated this revision to Diff 60021.<br />leinir added a comment.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21721">View Revision</a></tr></table><br /><div><div><p>Highlights: NewStuffButton, basic Kiosk support (needs more clever and user-facing mention of why the thing they just tried to do didn't happen/do anything), various fixing, cleanup, and sanity work.</p>

<ul class="remarkup-list">

<li class="remarkup-list-item">Fix logic for canFetchMore (initial state was a touch funny)</li>

<li class="remarkup-list-item">Explicitly request the listed categories for searching</li>

<li class="remarkup-list-item">Fix the emptiness issue in the proper place, and properly</li>

<li class="remarkup-list-item">Don't need to set this, now it's a proper model</li>

<li class="remarkup-list-item">Slightly more roundabout, but saner way for the API to handle the engine</li>

<li class="remarkup-list-item">Missed two files in previous commit</li>

<li class="remarkup-list-item">Allow opening any random knsrc file on the user's system</li>

<li class="remarkup-list-item">Expose a changedEntries property on the KNSQuick Engine</li>

<li class="remarkup-list-item">Import the proper NewStuff version</li>

<li class="remarkup-list-item">Add the initial version of a KNSQuick Button</li>

<li class="remarkup-list-item">Add a NewStuff.Button to the khns-dialog test app</li>

<li class="remarkup-list-item">Add allowedByKiosk in the Quick engine, and expose it</li>

<li class="remarkup-list-item">Add allowedByKiosk, and mark a few things invokable</li>

<li class="remarkup-list-item">Add a NewStuffDialog component (and content)</li>

<li class="remarkup-list-item">Minor doc change</li>

<li class="remarkup-list-item">Add the NewStuffDialog and NewStuffDialogContent components</li>

<li class="remarkup-list-item">Much simpler NewStuffButton (and use the Engine's kiosk info)</li>

</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D21721?vs=59510&id=60021">https://phabricator.kde.org/D21721?vs=59510&id=60021</a></div></div><br /><div><strong>BRANCH</strong><div><div>knsquick-feature-parity-with-kns (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21721">https://phabricator.kde.org/D21721</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/attica/atticaprovider.cpp<br />

src/attica/atticaprovider_p.h<br />

src/core/CMakeLists.txt<br />

src/core/commentsmodel.cpp<br />

src/core/commentsmodel.h<br />

src/core/engine.cpp<br />

src/core/engine.h<br />

src/core/entryinternal.cpp<br />

src/core/installation.cpp<br />

src/core/itemsmodel.cpp<br />

src/core/itemsmodel.h<br />

src/core/provider.h<br />

src/core/question.h<br />

src/qtquick/CMakeLists.txt<br />

src/qtquick/categoriesmodel.cpp<br />

src/qtquick/categoriesmodel.h<br />

src/qtquick/qml/ConditionalLoader.qml<br />

src/qtquick/qml/EntryCommentDelegate.qml<br />

src/qtquick/qml/EntryCommentsPage.qml<br />

src/qtquick/qml/EntryScreenshots.qml<br />

src/qtquick/qml/GridTileDelegate.qml<br />

src/qtquick/qml/NewStuffButton.qml<br />

src/qtquick/qml/NewStuffDialog.qml<br />

src/qtquick/qml/NewStuffDialogContent.qml<br />

src/qtquick/qml/NewStuffDownloadItemsSheet.qml<br />

src/qtquick/qml/NewStuffEntryDetails.qml<br />

src/qtquick/qml/NewStuffPage.qml<br />

src/qtquick/qml/NewStuffQuestionAsker.qml<br />

src/qtquick/qml/Rating.qml<br />

src/qtquick/qml/Shadow.qml<br />

src/qtquick/qmldir<br />

src/qtquick/qmlplugin.cpp<br />

src/qtquick/quickengine.cpp<br />

src/qtquick/quickengine.h<br />

src/qtquick/quickitemsmodel.cpp<br />

src/qtquick/quickitemsmodel.h<br />

src/qtquick/quickquestionlistener.cpp<br />

src/qtquick/quickquestionlistener.h<br />

tests/CMakeLists.txt<br />

tests/khotnewstuff-dialog-ui/main.qml<br />

tests/khotnewstuff-dialog.cpp</div></div></div><br /><div><strong>To: </strong>leinir<br /><strong>Cc: </strong>ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns<br /></div>