<table><tr><td style="">bruns created this revision.<br />bruns added reviewers: Baloo, ngraham, astippich, poboiko.<br />Herald added projects: Frameworks, Baloo.<br />Herald added a subscriber: kde-frameworks-devel.<br />bruns requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21839">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>All users of TermGenerator::termList do not use QStrings but UTF-8<br />
ByteArrays. Remove repetitive code.</p>
<p>While at it, make the lists const to avoid detach on iteration.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>ctest</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>BRANCH</strong><div><div>cleanup</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21839">https://phabricator.kde.org/D21839</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/engine/termgenerator.cpp<br />
src/engine/termgenerator.h<br />
src/lib/searchstore.cpp</div></div></div><br /><div><strong>To: </strong>bruns, Baloo, ngraham, astippich, poboiko<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>