<table><tr><td style="">bruns added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21788">View Revision</a></tr></table><br /><div><div><p>Please put the dead code removal in a separate review.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21788#inline-122709">View Inline</a><span style="color: #4b4d51; font-weight: bold;">svg.cpp:111</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">contentsAsString</span><span class="p">(</span><span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">fromLatin1</span><span class="p">(</span><span class="n">contents</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QRegExp</span> <span style="color: #004012">idExpr</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"id</span><span style="color: #bb6622">\\</span><span style="color: #766510">s*=</span><span style="color: #bb6622">\\</span><span style="color: #766510">s*(['</span><span style="color: #bb6622">\"</span><span style="color: #766510">])</span><span class="p">(</span><span class="err">\\</span><span class="n">d</span><span style="color: #aa2211">+-</span><span class="err">\\</span><span class="n">d</span><span style="color: #aa2211">+-</span><span class="p">.</span><span style="color: #aa2211">*</span><span class="p">)</span><span class="err">\\</span><span style="color: #601200">1</span><span style="color: #766510">"))</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">static</span></span><span class="bright"> </span><span class="n">QRegExp</span> <span style="color: #004012">idExpr</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"id</span><span style="color: #bb6622">\\</span><span style="color: #766510">s*=</span><span style="color: #bb6622">\\</span><span style="color: #766510">s*(['</span><span style="color: #bb6622">\"</span><span style="color: #766510">])</span><span class="p">(</span><span class="err">\\</span><span class="n">d</span><span style="color: #aa2211">+-</span><span class="err">\\</span><span class="n">d</span><span style="color: #aa2211">+-</span><span class="p">.</span><span style="color: #aa2211">*</span><span class="p">)</span><span class="err">\\</span><span style="color: #601200">1</span><span style="color: #766510">"))</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">idExpr</span><span class="p">.</span><span class="n">setMinimal</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please use a QRegularExpression with lazy quantifiers, you can use <tt style="background: #ebebeb; font-size: 13px;">const static</tt> then, no need for <tt style="background: #ebebeb; font-size: 13px;">QRegExp.setMinimal(true)</tt>.<br />
Just replace <tt style="background: #ebebeb; font-size: 13px;">*</tt>/<tt style="background: #ebebeb; font-size: 13px;">+</tt> with <tt style="background: #ebebeb; font-size: 13px;">*?</tt>/<tt style="background: #ebebeb; font-size: 13px;">+?</tt>.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21788">https://phabricator.kde.org/D21788</a></div></div><br /><div><strong>To: </strong>apol, Plasma, Frameworks<br /><strong>Cc: </strong>bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham<br /></div>