<table><tr><td style="">poboiko added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21509">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21509#inline-121211">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bruns</span> wrote in <span style="color: #4b4d51; font-weight: bold;">unindexedfileiteratortest.cpp:100</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Make this plain members, not pointers.<br />
Also, one temporary dir is enough, you can put the db and the test tree side-by-side.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I wanted both DB and directory tree to be recreated from scratch for each test, since tests modify DB or rename folders, and thus can affect each other. That's why I made them to be pointers.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21509#inline-121254">View Inline</a><span style="color: #4b4d51; font-weight: bold;">unindexedfileiterator.cpp:118</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">auto</span> <span class="n">fileMTime</span> <span style="color: #aa2211">=</span> <span class="n">fileInfo</span><span class="p">.</span><span class="n">metadataChangeTime</span><span class="p">().</span><span class="n">toTime_t</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">timeInfo</span><span class="p">.</span><span class="n">cTime</span> <span style="color: #aa2211">!=</span> <span class="n">fileMTime</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_cTimeChanged</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I wanted to note that this line is messed up a bit: either <tt style="background: #ebebeb; font-size: 13px;">fileMTime</tt> should be renamed to <tt style="background: #ebebeb; font-size: 13px;">fileCTime</tt>, or even removed, just like three lines above. <br />
(it looks like the variable was introduced some time ago inside <tt style="background: #ebebeb; font-size: 13px;">#ifdef QT < 5.10.0</tt>, which was removed recently with Qt dependency bump).</p>
<p style="padding: 0; margin: 8px;">Since that's just some cosmetic change, I can change it in this patch as well. Or should I make a new one?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21509#inline-121206">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bruns</span> wrote in <span style="color: #4b4d51; font-weight: bold;">unindexedfileiterator.cpp:122</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">thats wrong:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">$:/tmp> touch dir
$:/tmp> stat dir
File: dir
Size: 0 Blocks: 0 IO Block: 4096 regular empty file
Device: 3fh/63d Inode: 1892961 Links: 1
Access: (0644/-rw-r--r--) Uid: ( 1000/ sbruens) Gid: ( 100/ users)
Access: 2019-06-03 19:21:57.764626372 +0200
Modify: 2019-06-03 19:21:57.764626372 +0200
Change: 2019-06-03 19:21:57.764626372 +0200
Birth: 2019-06-03 19:21:57.764626372 +0200
$:/tmp> mv dir dir_renamed
$:/tmp> stat dir_renamed
File: dir_renamed
Size: 0 Blocks: 0 IO Block: 4096 regular empty file
Device: 3fh/63d Inode: 1892961 Links: 1
Access: (0644/-rw-r--r--) Uid: ( 1000/ sbruens) Gid: ( 100/ users)
Access: 2019-06-03 19:21:57.764626372 +0200
Modify: 2019-06-03 19:21:57.764626372 +0200
Change: 2019-06-03 19:22:07.096601727 +0200
Birth: 2019-06-03 19:21:57.764626372 +0200</pre></div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Right, sorry, I've mixed them up. Damn russian locale.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21509#inline-121209">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bruns</span> wrote in <span style="color: #4b4d51; font-weight: bold;">unindexedfileiterator.cpp:130</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">The comment does not match - the mtime changes when something <strong>in</strong> the directory is modified, when the directory is renamed, the ctime changes.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The comment is not mine - but that's precisely what it says. We don't want to reindex a directory every time something inside it modifies.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21509">https://phabricator.kde.org/D21509</a></div></div><br /><div><strong>To: </strong>poboiko, Frameworks, Baloo, bruns<br /><strong>Cc: </strong>kde-frameworks-devel, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>