<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21533">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21533#inline-121005">View Inline</a><span style="color: #4b4d51; font-weight: bold;">propertyinfotest.cpp:134</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">{</span> <span class="n">Property</span><span style="color: #aa2211">::</span><span class="n">PhotoExposureTime</span><span class="p">,</span> <span style="color: #304a96">true</span><span class="p">,</span> <span style="color: #601200">0.0015625</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">0.00156</span>"</span><span class="p">)},</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">{</span> <span class="n">Property</span><span style="color: #aa2211">::</span><span class="n">PhotoExposureBiasValue</span><span class="p">,</span> <span style="color: #304a96">true</span><span class="p">,</span> <span style="color: #601200">0.3333333</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">0.33</span>3"</span><span class="p">)},</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span> <span class="n">Property</span><span style="color: #aa2211">::</span><span class="n">PhotoExposureTime</span><span class="p">,</span> <span style="color: #304a96">true</span><span class="p">,</span> <span style="color: #601200">0.0015625</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">1/640</span>"</span><span class="p">)},</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span> <span class="n">Property</span><span style="color: #aa2211">::</span><span class="n">PhotoExposureBiasValue</span><span class="p">,</span> <span style="color: #304a96">true</span><span class="p">,</span> <span style="color: #601200">0.3333333</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">1/</span>3"</span><span class="p">)},</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">{</span> <span class="n">Property</span><span style="color: #aa2211">::</span><span class="n">ReplayGainAlbumGain</span><span class="p">,</span> <span style="color: #304a96">true</span><span class="p">,</span> <span style="color: #aa2211">-</span><span style="color: #601200">9.90</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"-9.9"</span><span class="p">)},</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please add two more testcases for exposure bias:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">negative bias</li>
<li class="remarkup-list-item">abs(bias) > 1</li>
</ol></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21533#inline-121004">View Inline</a><span style="color: #4b4d51; font-weight: bold;">formatstrings.cpp:161</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">QString</span> <span class="n">FormatStrings</span><span style="color: #aa2211">::</span><span class="n">formatAsDoubleOrRationale</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QVariant</span><span style="color: #aa2211">&</span> <span class="n">value</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Rational, without 'e'</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21533#inline-121003">View Inline</a><span style="color: #4b4d51; font-weight: bold;">formatstrings.cpp:167</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span class="n">reciprocal</span> <span style="color: #aa2211">=</span> <span class="n">round</span><span class="p">(</span><span style="color: #601200">1.0</span> <span style="color: #aa2211">/</span> <span class="n">val</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span style="color: #004012">i18nc</span><span class="p">(</span><span style="color: #766510">"Rational number smaller than 1"</span><span class="p">,</span> <span style="color: #766510">"1/%1"</span><span class="p">,</span> <span class="n">reciprocal</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This will give a wrong result (1/2) for 0.4 seconds.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21533">https://phabricator.kde.org/D21533</a></div></div><br /><div><strong>To: </strong>astippich, bruns, ngraham<br /><strong>Cc: </strong>kde-frameworks-devel, Baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>