<table><tr><td style="">bruns added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21379">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D21379#471513" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D21379#471513</a>, <a href="https://phabricator.kde.org/p/broulik/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@broulik</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>So, you want me to change that <tt style="background: #ebebeb; font-size: 13px;">1</tt> to <tt style="background: #ebebeb; font-size: 13px;">QVariant()</tt> then?</p></div>
</blockquote>

<p>I think that is completely sufficient, yes.</p>

<p>In all the other places, the <tt style="background: #ebebeb; font-size: 13px;">!QVariant::toString().isEmpty()</tt> and <tt style="background: #ebebeb; font-size: 13px;">QVariant::toInt() == 1</tt> should be replaced by just <tt style="background: #ebebeb; font-size: 13px;">QVariant::isValid()</tt></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R245 Solid</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21379">https://phabricator.kde.org/D21379</a></div></div><br /><div><strong>To: </strong>broulik, Frameworks, davidedmundson, bruns<br /><strong>Cc: </strong>apol, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>