<table><tr><td style="">jglogowski added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21249">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21249#inline-119642">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kfilewidgettest.cpp:88</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">... use setUrls *to* auto-select ODT filter?</p>
<p style="padding: 0; margin: 8px;">("to" is missing)</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No. The first line is missing a point or semicolon, if you read the comment like a sentence. I had two independent comments in mind. Or some kind of annotation (*) to make it look more like a list.</p>
<p style="padding: 0; margin: 8px;">The first line is a general comment, the 2nd describes the actual test case.. I know the blocking is documented, but it's still not expected behavior. At least I was puzzled and even read the code before the API doc, as I suspected a bug somewhere (that didn't exclude my code).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21249#inline-119653">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfilewidgettest.cpp:94</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// select 2nd duplicate XML filter</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// see bug 407642</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">fw</span><span class="p">.</span><span class="n">filterWidget</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setCurrentFilter</span><span class="p">(</span><span style="color: #766510">"*.xml *.b|DocBook (.xml)"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">From your POV this probably has the same problem then the first comment. I'll change it to:</p>
<p style="padding: 0; margin: 8px;">// select 2nd duplicate XML filter (see bug 407642)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21249#inline-119639">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kfilewidget.cpp:2456</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">This method could (and should) be marked as const, now.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Will do.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21249#inline-119641">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kfilewidget.cpp:2492</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I don't really understand what this comment is doing here, it seems unrelated to the next line of code. Is it just a longer version of the comment on line 2499?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Kind of a reverse comment of line 2499. My original code tested for '*' and I found it none-obvious to omit that match test here. I even tested both variants with the bug program to be sure. The comment is a little disturbing, as there wasn't any code handling '*' yet. I'll change it to:</p>
<p style="padding: 0; margin: 8px;">// accept any match to honor the user's selection; see later code handling the "*" match</p>
<p style="padding: 0; margin: 8px;">Or I drop it. I would keep it. Other suggestions?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21249">https://phabricator.kde.org/D21249</a></div></div><br /><div><strong>To: </strong>jglogowski, Frameworks, ngraham, dfaure<br /><strong>Cc: </strong>elvisangelaccio, ngraham, michaelweghorn, kde-frameworks-devel, michaelh, bruns<br /></div>