<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21327">View Revision</a></tr></table><br /><div><div><p>Hope this helps ^^'</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21327#inline-119755">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sambausershareplugin.cpp:155</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">SIGNAL</span><span class="p">(</span><span class="n">package</span><span class="p">(</span><span class="n">PackageKit</span><span style="color: #aa2211">::</span><span class="n">Transaction</span><span style="color: #aa2211">::</span><span class="n">Info</span><span class="p">,</span><span class="n">QString</span><span class="p">,</span><span class="n">QString</span><span class="p">)),</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">SLOT</span><span class="p">(</span><span class="n">packageInstall</span><span class="p">(</span><span class="n">PackageKit</span><span style="color: #aa2211">::</span><span class="n">Transaction</span><span style="color: #aa2211">::</span><span class="n">Info</span><span class="p">,</span><span class="n">QString</span><span class="p">,</span><span class="n">QString</span><span class="p">)));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is a bit weird now, because you'll be getting N packages, and when they all finish installing they will all call "packageFinished" which I could expect to break in different ways.</p>

<p style="padding: 0; margin: 8px;">It would look something like:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">PackageKit::Transaction *transaction = PackageKit::Daemon::resolve(distroSambaPackages, PackageKit::Transaction::FilterArch);

QSharedPointer<QStringList> pkgids(new QStringList);
connect(transaction,
        &PackageKit::Transaction::package,
        [pkgids] (PackageKit::Transaction::Info info, const QString& packageId, const QString& summary) { pkgids.append(packageId); });
connect(t, &PackageKit::Transaction::finished, [pkgids] (PackageKit::Transaction::Exit exit) {
    if (exit != PackageKit::Transaction::ExitSuccess)
        return;
    auto t = PackageKit::Daemon::installPackage(*pkgids);
    //t....
})</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R432 File Sharing (Samba) integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21327">https://phabricator.kde.org/D21327</a></div></div><br /><div><strong>To: </strong>ngraham, apol, Frameworks<br /></div>