<table><tr><td style="">jglogowski updated this revision to Diff 58316.<br />jglogowski added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21249">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">Return a QString from findMatchingFilter and handle setCurrentFilter in main function</li>
<li class="remarkup-list-item">Add filter unit test</li>
</ul>
<p>For a manual test I added a "Raw (*)" filter to the bug test program.<br />
After playing with it, I decided to not test the currentFilter() against QLatin1String("*"), so if a user selects such an entry, it'll disable auto-filter and -extension selection.<br />
Since we never auto-select the "*" filter, this honors the users filter selection.</p>
<p>Took me a while to write the unit test without QDialog. I was a bit tricked by Q_ASSERT used in other tests ;-)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D21249?vs=58291&id=58316">https://phabricator.kde.org/D21249?vs=58291&id=58316</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21249">https://phabricator.kde.org/D21249</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/filewidgets/kfilewidget.cpp<br />
tests/CMakeLists.txt<br />
tests/kfilewidgettest_filter.cpp</div></div></div><br /><div><strong>To: </strong>jglogowski, Frameworks, ngraham, dfaure<br /><strong>Cc: </strong>elvisangelaccio, ngraham, michaelweghorn, kde-frameworks-devel, michaelh, bruns<br /></div>