<table><tr><td style="">loh.tar updated this revision to Diff 57125.<br />loh.tar retitled this revision from "DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection" to "Add option to treat some chars also as "auto bracket" only when we have a selection".<br />loh.tar edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-fftnecrenjms3m5/">(Show Details)</a><br />loh.tar edited the test plan for this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-wq54fajfpu3fjwk/">(Show Details)</a><br />loh.tar added a subscriber: ngraham.<br />loh.tar added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17693">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">Make feature optional by new config interface</li>
<li class="remarkup-list-item">Make feature independent from auto bracket option</li>
<li class="remarkup-list-item">Remove redundant const QChar typedChar</li>
<li class="remarkup-list-item">Use dummy config value from dialog</li>
</ul>
<p>TODO</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Add QLineEdit or similar to config dialog</li>
<li class="remarkup-list-item">Oops, remove/change special angle bracket stuff</li>
</ul>
<p>QUESTIONS</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Would it be this way in general OK? <a href="https://phabricator.kde.org/p/mwolff/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@mwolff</a></li>
<li class="remarkup-list-item">Is the chosen option name fitting and descriptive enough? <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a></li>
</ul></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">My first attempt was only to add angle brackets to the auto bracket code but <br />
that caused surprising odd behavior in the normal edit flow, so it needs to be <br />
done in a special way which obviously cause no trouble. <br />
<br />
Once done this way, I had the idea to add much more char to this special <br />
handlin</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">With that option you can add e.</span>g. <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">Some of these may handy when write Markdown</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Markdown markups</span>, <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">some perhaps elsewhere.<br />
<br />
- Improve readability of auto bracket code</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">or what ever else may handy,</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">- Harmonize QChar param as const value, not reference</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">afterwards to some text like you can do with quotes and enabled auto brackets<br />
</span><br />
- Remove <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">unneeded code</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">redundant const QChar typedChar</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">- Avoid chars[0] </span></div></div></div><br /><div><strong>CHANGES TO TEST PLAN</strong><div><div style="white-space: pre-wrap; color: #74777D;"><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Should you really try it, note above the TODO and look at the code. You may need to change the auto bracket option to see any effect</span></div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D17693?vs=50061&id=57125">https://phabricator.kde.org/D17693?vs=50061&id=57125</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17693">https://phabricator.kde.org/D17693</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/dialogs/katedialogs.cpp<br />
src/document/katedocument.cpp<br />
src/utils/kateconfig.cpp<br />
src/utils/kateconfig.h</div></div></div><br /><div><strong>To: </strong>loh.tar, KTextEditor, cullmann, mwolff<br /><strong>Cc: </strong>ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, KTextEditor, domson, michaelh, bruns, demsking, dhaumann<br /></div>