<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20693">View Revision</a></tr></table><br /><div><div><p>This patch doesn't apply:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"> INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D20693.
Checking patch src/ui/imagepreviewwidget_p.h...
Checking patch src/ui/imagepreviewwidget.cpp...
Checking patch data/thumb_frame.png...
error: the patch applies to 'data/thumb_frame.png' (afaf432793864e1fb3f1fc27aa1d53689f2243b5), which does not match the current contents.
error: data/thumb_frame.png: patch does not apply
Checking patch data/CMakeLists.txt...
Applied patch src/ui/imagepreviewwidget_p.h cleanly.
Applied patch src/ui/imagepreviewwidget.cpp cleanly.
Applied patch data/CMakeLists.txt cleanly.

 Patch Failed! 
Usage Exception: Unable to apply patch!</pre></div>

<p>Also it would be helpful if you used <tt style="background: #ebebeb; font-size: 13px;">arc</tt> for your patches, since then you can see the context here in the web UI: <a href="https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches</a></p>

<p>Additionally, it's nice if you can add a screenshot to the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Test Plan</span></span></span> section for patches that involve UI changes: <a href="https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20693">https://phabricator.kde.org/D20693</a></div></div><br /><div><strong>To: </strong>leinir, KNewStuff, ngraham, sitter<br /><strong>Cc: </strong>kde-frameworks-devel, KNewStuff, michaelh, ZrenBot, ngraham, bruns<br /></div>