<table><tr><td style="">ngraham updated this revision to Diff 56465.<br />ngraham marked an inline comment as done.<br />ngraham edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-sakycrtwxwrli2g/">(Show Details)</a><br />ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20283">View Revision</a></tr></table><br /><div><div><p>Use implicitHeights for headers and footers</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>FIXED-IN: 5.58<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"><br />
<br />
</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R296 KDeclarative</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D20283?vs=56462&id=56465">https://phabricator.kde.org/D20283?vs=56462&id=56465</a></div></div><br /><div><strong>BRANCH</strong><div><div>simplekcm-better-maximum-height (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20283">https://phabricator.kde.org/D20283</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml<br />
src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp</div></div></div><br /><div><strong>To: </strong>ngraham, Plasma, mart, broulik<br /><strong>Cc: </strong>broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>