<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, mart, hein.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20594">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>It is all in <tt style="background: #ebebeb; font-size: 13px;">MobileTextSelection</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">Private</tt> now.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>I dont understand why in every component there's two of them, one in a <tt style="background: #ebebeb; font-size: 13px;">Component</tt> and the other not but whatever. This works now.</p>
<p>Note that when moving files about in plasmacomponents 3 you must do a clean build as our cmake foo to change the import numbers doesn't pick that up which is probably why this breakage went unnoticed. It also only broke here once I did a clean build or got the packages shipped from neon... Also, I would appreciate if you could test media controller when you do plasma components 3 changes as this seems to be the only user of that stuff right now and constantly breaks for doing so ...</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20594">https://phabricator.kde.org/D20594</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/declarativeimports/plasmacomponents3/ComboBox.qml<br />
src/declarativeimports/plasmacomponents3/TextArea.qml<br />
src/declarativeimports/plasmacomponents3/TextField.qml</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, mart, hein<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>