<table><tr><td style="">cullmann added reviewers: ngraham, dhaumann.<br />cullmann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20606">View Revision</a></tr></table><br /><div><div><p>I think the feature is nice.</p>
<p>For the code: I would like to have comments for the function decls. to tell what they really do.<br />
e.g. toggleFoldingInRange needs a short summary what it does, the comments in the function themself are helpful.</p>
<p>Others, feedback?</p>
<p>The only real issue for the "usability" is imho the lack of discoverability.<br />
Perhaps this should in addition get an action in the "Code Folding" menu?<br />
The people can have a shortcut for it, too, if wanted.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20606">https://phabricator.kde.org/D20606</a></div></div><br /><div><strong>To: </strong>loh.tar, KTextEditor, cullmann, ngraham, dhaumann<br /><strong>Cc: </strong>kwrite-devel, kde-frameworks-devel, KTextEditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>