<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20096">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20096#inline-114971">View Inline</a><span style="color: #4b4d51; font-weight: bold;">file.cpp:890</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">break</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">default</span><span style="color: #aa2211">:</span> <span style="color: #74777d">// case 0:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// filename, access, type, size, linkdest</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is wrong in case someone uses details > 3, should be <tt style="background: #ebebeb; font-size: 13px;">case 0: reserve(5)</tt>, <tt style="background: #ebebeb; font-size: 13px;">case 3: default: reserve(15)</tt> .<br />
all checks below do e.g <tt style="background: #ebebeb; font-size: 13px;">if (details > 2)</tt>, so handle 5 the same as 3.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20096#inline-114972">View Inline</a><span style="color: #4b4d51; font-weight: bold;">file.cpp:939</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">#endif</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span class="n">bufferSize</span> <span style="color: #aa2211">=</span> <span class="n">qBound</span><span class="p">(</span><span class="n">lowerBound</span><span class="p">,</span> <span class="n">size</span> <span style="color: #aa2211">+</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">higherBound</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QByteArray</span> <span class="n">linkTargetBuffer</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">missing space, <tt style="background: #ebebeb; font-size: 13px;">size + 1</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>arcpatch-D20096</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20096">https://phabricator.kde.org/D20096</a></div></div><br /><div><strong>To: </strong>meven, Frameworks, dfaure, fvogt, bruns, broulik<br /><strong>Cc: </strong>anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns<br /></div>