<table><tr><td style="">arrowd added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18296">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D18296#445829" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D18296#445829</a>, <a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Is the makeURL function still used, or should it be removed now?</p></div>
</blockquote>
<p>Yep, it is still used in a bunch of other places.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18296#inline-114501">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">urlinfo.h:39</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">const QString &</p>
<p style="padding: 0; margin: 8px;">And what if it's a URL? At this point this string is pathOrUrl.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">const QString &</p></blockquote>
<p style="padding: 0; margin: 8px;">There is <tt style="background: #ebebeb; font-size: 13px;">path.chop(match.capturedLength());</tt>, which requires non-const <tt style="background: #ebebeb; font-size: 13px;">QString</tt>.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">And what if it's a URL? At this point this string is pathOrUrl.</p></blockquote>
<p style="padding: 0; margin: 8px;">Well, <tt style="background: #ebebeb; font-size: 13px;">if (QFile::exists(path))</tt> will return false in this case, and <tt style="background: #ebebeb; font-size: 13px;">url</tt> would get populated by <tt style="background: #ebebeb; font-size: 13px;">url = QUrl::fromUserInput()</tt>. What's wrong with that?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18296#inline-114502">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">urlinfo.h:77</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I'm not sure about AssumeLocalFile, in the context of kde-open.<br />
This is about opening existing files, not creating new files.<br />
So it should be removed.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It is not about creating missing files, but reaction to user typos. If I try to open <tt style="background: #ebebeb; font-size: 13px;">fiel.txt</tt> instead of a <tt style="background: #ebebeb; font-size: 13px;">file.txt</tt>, I want to get a "no such file or directory error message" instead of popping browser trying to open "http://fiel.txt".</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R126 KDE CLI Utilities</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18296">https://phabricator.kde.org/D18296</a></div></div><br /><div><strong>To: </strong>arrowd, Plasma, KTextEditor, broulik, Frameworks, pino, cfeck, dfaure, elvisangelaccio<br /><strong>Cc: </strong>apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>