<table><tr><td style="">kossebau abandoned this revision.<br />kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20261">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D20261#443859" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D20261#443859</a>, <a href="https://phabricator.kde.org/p/broulik/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@broulik</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I don't see how this could work. IconItem uses the first section as filename, for <tt style="background: #ebebeb; font-size: 13px;">active-quassel-tray</tt> the word <tt style="background: #ebebeb; font-size: 13px;">active</tt> and looks for an active.svgz which there isn't. This is a bug in Quassel, a violation of the FDO spec, it should have ebeen <tt style="background: #ebebeb; font-size: 13px;">quassel-tray-inactive</tt> or something, ordered from generic to most specific.</p></div>
</blockquote>

<p>So much for blindly done patches relying on testing by actual users :)</p>

<p>Indeed, <tt style="background: #ebebeb; font-size: 13px;">IconItem</tt> uses this logic:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">m_svgIcon->setImagePath(QLatin1String("icons/") + sourceString.section(QLatin1Char('-'), 0, 0));</pre></div>

<p>so this change will not work.</p>

<p>But I wonder if this isn't a rather once heuristically-driven assumption of Plasma, over anything specified at freedesktop.org?<br />
I could not find anything related in both<br />
<a href="https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/" class="remarkup-link" target="_blank" rel="noreferrer">https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/</a><br />
<a href="https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/Icons/" class="remarkup-link" target="_blank" rel="noreferrer">https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/Icons/</a><br />
as well as<br />
<a href="https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#file_formats" class="remarkup-link" target="_blank" rel="noreferrer">https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#file_formats</a></p>

<p>Where should/could Quassel developers be pointed to? (Besides, they also have some "-inverted" variant based on a config option, which somehow complicates things even more, besides the complexity of Plasma theming vs. normal icon theming ;) ).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20261">https://phabricator.kde.org/D20261</a></div></div><br /><div><strong>To: </strong>kossebau, Plasma, VDG<br /><strong>Cc: </strong>broulik, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>