<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20166">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D20166#443916" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D20166#443916</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D20166#443781" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D20166#443781</a>, <a href="https://phabricator.kde.org/p/kossebau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@kossebau</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>If so, I would propose to merge it after KDE Frameworks 5.57 has been branched this WE, i.e. merge Friday next week for another 7 days of consideration, but with some weeks before the next release so people using master can test-drive things some more before release, not only me :)</p></div>
</blockquote>
<p>Makes sense to me. That said, I just gave this a whirl and got a CMake error immediately:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">CMake Error at src/desktoptheme/CMakeLists.txt:30 (message):
No files passed when calling plasma_install_desktoptheme_svgs.
Call Stack (most recent call first):
src/desktoptheme/oxygen/CMakeLists.txt:5 (plasma_install_desktoptheme_svgs)</pre></div></div>
</blockquote>
<p>Yes, because an important hint was already moved out of sight, so let my recite my first comment:</p>
<p>The SVGZ -> SVG conversion of all files not included in this uploaded patch, to keep it reviewable.</p>
<p>Locally do this:</p>
<p>Store a file <tt style="background: #ebebeb; font-size: 13px;">svgztosvg.sh</tt> with this content in <tt style="background: #ebebeb; font-size: 13px;">src/desktoptheme</tt>:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="sh" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="ch">#!/bin/sh</span>
<span style="color: #001294">SVGZ</span><span style="color: #aa2211">=</span><span style="color: #001294">$1</span>
<span style="color: #aa4000">if</span> <span style="color: #aa2211">[</span> ! -f <span style="color: #766510">"</span>$<span style="color: #766510">SVGZ"</span> <span style="color: #aa2211">]</span><span class="p">;</span> <span style="color: #aa4000">then</span>
<span style="color: #304a96">echo</span> <span style="color: #766510">"File not found: \"</span>$<span style="color: #766510">SVGZ\""</span>
<span style="color: #304a96">exit</span> 1
<span style="color: #aa4000">fi</span>
<span style="color: #001294">SVG</span><span style="color: #aa2211">=</span><span style="color: #bb66bb">${</span><span style="color: #001294">SVGZ</span><span class="p">%.svgz</span><span style="color: #bb66bb">}</span>.svg
zcat $SVGZ > $SVG
rm $SVGZ</pre></div>
<p>Then on the commandline do this:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">cd plasma-framework/src/desktoptheme
find . -name "*.svgz" -exec sh svgztosvg.sh {} \;</pre></div>
<p>Once done, do e.g. this to restore SVGZ files:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">find . -name "*.svg" -exec rm {} \;
git checkout air breeze oxygen</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20166">https://phabricator.kde.org/D20166</a></div></div><br /><div><strong>To: </strong>kossebau, Plasma, VDG<br /><strong>Cc: </strong>bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh<br /></div>