<table><tr><td style="">JJRcop added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20181">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D20181#441887" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D20181#441887</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@aacid</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Can we use <a href="https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html" class="remarkup-link" target="_blank" rel="noreferrer">https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html</a> instead of doing this again?</p></div>
</blockquote>

<p>I think that's out of scope for this patch. It should be done in another patch so we can refactor <a href="https://phabricator.kde.org/source/kunitconversion/browse/master/src/frequency.cpp;99cfd52570b747e46d7657e1e11d2605b9a09b81$33" class="remarkup-link" target="_blank" rel="noreferrer">Frequency</a> and <a href="https://phabricator.kde.org/source/kunitconversion/browse/master/src/frequency.cpp;99cfd52570b747e46d7657e1e11d2605b9a09b81$33" class="remarkup-link" target="_blank" rel="noreferrer">Length</a> to use KFormat as well.</p></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20181">https://phabricator.kde.org/D20181</a></div></div><br /><div><strong>To: </strong>JJRcop, broulik, Plasma, ngraham<br /><strong>Cc: </strong>aacid, ngraham, kde-frameworks-devel, michaelh, bruns<br /></div>