<table><tr><td style="">pino added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20143">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20143#inline-113442">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kra.cpp:22</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">static</span> <span style="color: #aa4000">constexpr</span> <span style="color: #aa4000">char</span> <span class="n">s_magic</span><span class="p">[]</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"application/x-krita"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">static</span> <span style="color: #aa4000">constexpr</span> <span style="color: #aa4000">int</span> <span class="n">s_magic_size</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">sizeof</span><span class="p">(</span><span class="n">s_magic</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this also counts the null terminator (as it is part of the static string)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20143#inline-113443">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kra.cpp:61</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">device</span><span style="color: #aa2211">-></span><span class="n">peek</span><span class="p">(</span><span class="n">buff</span><span class="p">,</span> <span style="color: #aa4000">sizeof</span><span class="p">(</span><span class="n">buff</span><span class="p">))</span> <span style="color: #aa2211">==</span> <span style="color: #aa4000">sizeof</span><span class="p">(</span><span class="n">buff</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">return</span> <span class="n">qstrcmp</span><span class="p">(</span><span class="n">buff</span> <span style="color: #aa2211">+</span> <span style="color: #601200">0x26</span><span class="p">,</span> <span class="bright"></span><span style="color: #766510"><span class="bright">"application/x-krita"</span></span><span class="p">)</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span class="n">qstr<span class="bright">n</span>cmp</span><span class="p">(</span><span class="n">buff</span> <span style="color: #aa2211">+</span> <span style="color: #601200">0x26</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">s_magic</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">s_magic_size</span></span><span class="p">)</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this can be memcmp even (slightly faster than str*cmp)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20143#inline-113444">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ora.cpp:21</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">static</span> <span style="color: #aa4000">constexpr</span> <span style="color: #aa4000">char</span> <span class="n">s_magic</span><span class="p">[]</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"image/openraster"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">static</span> <span style="color: #aa4000">constexpr</span> <span style="color: #aa4000">int</span> <span class="n">s_magic_size</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">sizeof</span><span class="p">(</span><span class="n">s_magic</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ditto</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20143#inline-113445">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ora.cpp:60</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">device</span><span style="color: #aa2211">-></span><span class="n">peek</span><span class="p">(</span><span class="n">buff</span><span class="p">,</span> <span style="color: #aa4000">sizeof</span><span class="p">(</span><span class="n">buff</span><span class="p">))</span> <span style="color: #aa2211">==</span> <span style="color: #aa4000">sizeof</span><span class="p">(</span><span class="n">buff</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">return</span> <span class="n">qstrcmp</span><span class="p">(</span><span class="n">buff</span> <span style="color: #aa2211">+</span> <span style="color: #601200">0x26</span><span class="p">,</span> <span class="bright"></span><span style="color: #766510"><span class="bright">"image/openraster"</span></span><span class="p">)</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span class="n">qstr<span class="bright">n</span>cmp</span><span class="p">(</span><span class="n">buff</span> <span style="color: #aa2211">+</span> <span style="color: #601200">0x26</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">s_magic</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">s_magic_size</span></span><span class="p">)</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ditto</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R287 KImageFormats</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20143">https://phabricator.kde.org/D20143</a></div></div><br /><div><strong>To: </strong>aacid<br /><strong>Cc: </strong>pino, security-team, rempt, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>