<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19887">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19887#inline-113190">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfileitem.cpp:362</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">item</span><span class="p">.</span><span class="n">m_bInitCalled</span> <span style="color: #aa2211">&&</span> <span class="n">m_bInitCalled</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">item</span><span class="p">.</span><span class="n">init</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There is one thing I've been wondering back and forth about: the alternative way of doing this, which is to call init() unconditionally and testing the bool first thing in there.<br />
The benefit is that it would reduce the code size overall, and greatly simplify the top of this method (two calls to init, done).<br />
The downside is that for the reader, a call to init() might in fact do nothing (and it reads like it's doing something, until going there to check). So it's maybeInit(), urgh.</p>

<p style="padding: 0; margin: 8px;">Ah, in another code base (QMimeType) I wrote ensureLoaded(). This could be ensureInitialized() ?</p>

<p style="padding: 0; margin: 8px;">Sorry for not suggesting this earlier. Do you agree that it would make the code better?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19887#inline-113187">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfileitem.cpp:609</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">d</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">m_</span>entry</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_LOCAL_PATH</span><span class="p">,</span> <span class="n">path</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">entry<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">()</span>.</span><span class="n">replace</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_LOCAL_PATH</span><span class="p">,</span> <span class="n">path</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No no, this won't work. entry() returns a copy, not a reference.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19887#inline-113188">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfileitem.cpp:663</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// Extract the local path from the KIO::UDSEntry</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">return</span> <span class="n">m_entry</span><span class="p">.</span><span class="n">stringValue</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_LOCAL_PATH</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">here entry() would work, no?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19887#inline-113189">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfileitem.cpp:1054</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QStringList</span> <span class="n">names</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="n"><span class="bright">d</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">m_</span>entry</span><span class="p">.</span><span class="n">stringValue</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_ICON_OVERLAY_NAMES</span><span class="p">).</span><span class="n">split</span><span class="p">(</span><span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">','</span><span class="p">),</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">SkipEmptyParts</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QStringList</span> <span class="n">names</span> <span style="color: #aa2211">=</span> <span class="n">entry<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">()</span>.</span><span class="n">stringValue</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_ICON_OVERLAY_NAMES</span><span class="p">).</span><span class="n">split</span><span class="p">(</span><span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">','</span><span class="p">),</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">SkipEmptyParts</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It's more fragile this way here, because the reader of this code won't see that d->m_bLink is initialized indirectly via entry() calling init().</p>

<p style="padding: 0; margin: 8px;">This is why I had only suggested to use entry() in a few places, not in those other places which need init() for other reasons anyway.</p>

<p style="padding: 0; margin: 8px;">By fragile it means, it works today, but any further work/refactoring of this code is likely to break.</p>

<p style="padding: 0; margin: 8px;">Same problem in linkDest().</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19887">https://phabricator.kde.org/D19887</a></div></div><br /><div><strong>To: </strong>hoffmannrobert, dfaure, Frameworks, Dolphin<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>