<table><tr><td style="">davidedmundson added subscribers: adridg, vonreth.<br />davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20007">View Revision</a></tr></table><br /><div><div><p>Awesome progress. Thanks ever so much.</p>
<p><a href="https://phabricator.kde.org/p/vonreth/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@vonreth</a> could you test the windows side for us and tell us how to do the unit test?</p>
<p><a href="https://phabricator.kde.org/p/adridg/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@adridg</a> could you run this on BSD. You should just need to run ./bin/kprocesslisttest and see if it passes.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20007#inline-112693">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kprocesslist.cpp:38</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">KProcessInfoPrivate</span><span style="color: #aa2211">::</span><span class="n">KProcessInfoPrivate</span><span class="p">(</span><span class="n">KProcessInfo</span><span style="color: #aa2211">*</span> <span class="n">q</span><span class="p">)</span> <span style="color: #aa2211">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">q_ptr</span><span class="p">(</span><span class="n">q</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">valid</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">we don't need a q_ptr</p>
<p style="padding: 0; margin: 8px;">It's only useful if the private object needs to signal things upwards. <br />
Our data structure is static.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20007#inline-112705">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kprocesslist.cpp:65</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">d_ptr</span><span style="color: #aa2211">-></span><span class="n">valid</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">d_ptr</span><span style="color: #aa2211">-></span><span class="n">pid</span> <span style="color: #aa2211">=</span> <span class="n">other</span><span class="p">.</span><span class="n">pid</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">x = ProcessInfo()<br />
x.valid() == false;<br />
y=x;<br />
y.valid() == true;</p>
<p style="padding: 0; margin: 8px;">But you can simplify all this and the other one to</p>
<p style="padding: 0; margin: 8px;">*d_ptr = *other.d_ptr;</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20007#inline-112707">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kprocesslist.cpp:72</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">KProcessInfo</span><span style="color: #aa2211">::~</span><span class="n">KProcessInfo</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">delete d_ptr;</p>
<p style="padding: 0; margin: 8px;">OR</p>
<p style="padding: 0; margin: 8px;">replace make d_ptr a QScopedPointer</p>
<p style="padding: 0; margin: 8px;">OR</p>
<p style="padding: 0; margin: 8px;">make it a QSharedDataPointer and our KProcessInfoPrivate inherit from QSharedData<br />
(which is a bit more work but my favourite option)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20007#inline-112708">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kprocesslist.h:51</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KProcessInfo</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KProcessInfo</span><span class="p">(</span><span class="n">qint64</span> <span class="n">pid</span><span class="p">,</span> <span class="n">QString</span> <span class="n">name</span><span class="p">,</span> <span class="n">QString</span> <span class="n">user</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KProcessInfo</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KProcessInfo</span> <span style="color: #aa2211">&</span><span class="n">other</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">qint64 pid, const QString &name, const QString &user</p>
<p style="padding: 0; margin: 8px;">it saves a string shallow copy</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20007#inline-112706">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kprocesslist_p.h:48-49</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">name</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">image</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">state</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">user</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We should probably either kill these 2 or use them.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20007">https://phabricator.kde.org/D20007</a></div></div><br /><div><strong>To: </strong>hallas, davidedmundson, broulik<br /><strong>Cc: </strong>vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>