<table><tr><td style="">bruns requested changes to this revision.<br />bruns added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20011">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20011#inline-112577">View Inline</a><span style="color: #4b4d51; font-weight: bold;">app.cpp:147</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">Q<span class="bright">String</span></span><span class="bright"> </span><span class="n"><span class="bright">mimet</span>ype</span> <span style="color: #aa2211">=</span> <span class="n">m_mimeDb</span><span class="p">.</span><span class="n">mimeTypeForFile</span><span class="p">(</span><span class="n">url</span><span class="p">,</span> <span class="n">QMimeDatabase</span><span style="color: #aa2211">::</span><span class="n">Match<span class="bright">Content</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">name</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Q<span class="bright">MimeType</span></span><span class="bright"> </span><span class="n"><span class="bright">extensionMimeT</span>ype</span> <span style="color: #aa2211">=</span> <span class="n">m_mimeDb</span><span class="p">.</span><span class="n">mimeTypeForFile</span><span class="p">(</span><span class="n">url</span><span class="p">,</span> <span class="n">QMimeDatabase</span><span style="color: #aa2211">::</span><span class="n">Match<span class="bright">Extension</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QMimeType</span> <span class="n">contentMimeType</span> <span style="color: #aa2211">=</span> <span class="n">m_mimeDb</span><span class="p">.</span><span class="n">mimeTypeForFile</span><span class="p">(</span><span class="n">url</span><span class="p">,</span> <span class="n">QMimeDatabase</span><span style="color: #aa2211">::</span><span class="n">MatchContent</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This only works correctly when the actual mimetype is the preferred one for this extension. See<br />
<a href="https://doc.qt.io/qt-5/qmimedatabase.html#mimeTypesForFileName" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qmimedatabase.html#mimeTypesForFileName</a></p>
<p style="padding: 0; margin: 8px;">Mismatching file (should be graphviz):</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">$> cat test.dot
# some comment
graph {}</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20011#inline-112581">View Inline</a><span style="color: #4b4d51; font-weight: bold;">app.cpp:154</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">mimetype</span> <span style="color: #aa2211">=</span> <span class="n">contentMimeType</span><span class="p">.</span><span class="n">name</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">qCDebug</span><span class="p">(</span><span class="n">BALOO</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Indexing"</span> <span style="color: #aa2211"><<</span> <span class="n">id</span> <span style="color: #aa2211"><<</span> <span class="n">url</span> <span style="color: #aa2211"><<</span> <span class="n">mimetype</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This should be a standalone function, to reuse it in e.g. the baloo-widgets temp extractor</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20011">https://phabricator.kde.org/D20011</a></div></div><br /><div><strong>To: </strong>astippich, Baloo, bruns<br /><strong>Cc: </strong>kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>