<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20012">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20012#inline-112389">View Inline</a><span style="color: #4b4d51; font-weight: bold;">propertyinfotest.cpp:97</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">framerate</span><span class="p">.</span><span class="n">formatAsDisplayString</span><span class="p">(</span><span class="n">QVariant</span><span class="p">(</span><span style="color: #601200">23</span><span class="p">)),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"23 fps"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">framerate</span><span class="p">.</span><span class="n">formatAsDisplayString</span><span class="p">(</span><span class="n">QVariant</span><span class="p">(</span><span style="color: #601200">23.976</span><span class="p">)),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">23.98</span> fps"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">framerate</span><span class="p">.</span><span class="n">formatAsDisplayString</span><span class="p">(</span><span class="n">QVariant</span><span class="p">(</span><span style="color: #601200">23.976</span><span class="p">)),</span> <span class="n">QString<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QLocale</span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="bright"></span><span class="n"><span class="bright">toString</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">23.98</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">QString</span>Literal</span><span class="p">(</span><span style="color: #766510">" fps"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This will of course fail as soon as someone translates fps, e.g. german "B/s", even more in RTL locales.</p>

<p style="padding: 0; margin: 8px;">Probably the better solution is to provide the whole string verbatim, and mark it with i18n. Until then, tests should be run with an en or C locale.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20012">https://phabricator.kde.org/D20012</a></div></div><br /><div><strong>To: </strong>astippich, bruns<br /><strong>Cc: </strong>kde-frameworks-devel, Baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>