<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19551">View Revision</a></tr></table><br /><div><div><p>This sadly breaks build with at least older versions of Phonon, as they have foreach loop in their public headers.</p>
<p>So this either needs a bump of the current</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">find_package(Phonon4Qt5 4.6.60 NO_MODULE)</pre></div>
<p>or adding the <tt style="background: #ebebeb; font-size: 13px;">QT_NO_FOREACH</tt> only if a newer working Phonon version is found.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R289 KNotifications</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19551">https://phabricator.kde.org/D19551</a></div></div><br /><div><strong>To: </strong>mlaurent, dfaure<br /><strong>Cc: </strong>kossebau, pino, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>