<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19812">View Revision</a></tr></table><br /><div><div><p>Neato! Looks pretty handy. Two issues I found:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">generate_web_data.sh isn't executable</li>
<li class="remarkup-list-item">I'd like to see this run as part of the build process, so that <tt style="background: #ebebeb; font-size: 13px;">index.html</tt> gets updated automatically, and so running it doesn't pollute your source folder since you're of course doing out-of-source builds :) Then you don't have to add the generated text files to .gitignore.</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R266 Breeze Icons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19812">https://phabricator.kde.org/D19812</a></div></div><br /><div><strong>To: </strong>guoyunhe, ngraham<br /><strong>Cc: </strong>ngraham, kde-frameworks-devel, michaelh, bruns<br /></div>