<table><tr><td style="">bruns requested changes to this revision.<br />bruns added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19696">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19696#inline-110458">View Inline</a><span style="color: #4b4d51; font-weight: bold;">blendercreator.cpp:57</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QPointer</span><span style="color: #aa2211"><</span><span class="n">KCompressionDevice</span><span style="color: #aa2211">></span> <span class="n">gzFile</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">file</span><span class="p">.</span><span class="n">peek</span><span class="p">(</span><span style="color: #601200">2</span><span class="p">).</span><span class="n">startsWith</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\x1F\x8B</span><span style="color: #766510">"</span><span class="p">))</span> <span class="p">{</span> <span style="color: #74777d">// gzip magic (each gzip member starts with ID1(0x1f) and ID2(0x8b))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">file</span><span class="p">.</span><span class="n">close</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think this is already done by the calling code - the thumbnailer gets only called when the mimetype matches.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19696#inline-110459">View Inline</a><span style="color: #4b4d51; font-weight: bold;">blendercreator.cpp:62</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">blendStream</span><span class="p">.</span><span class="n">setDevice</span><span class="p">(</span><span class="n">gzFile</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">} else {</tt> ...?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19696#inline-110460">View Inline</a><span style="color: #4b4d51; font-weight: bold;">blendercreator.cpp:73</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Example header: "BLENDER-257"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is missing the 'v' / 'V'</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19696#inline-110463">View Inline</a><span style="color: #4b4d51; font-weight: bold;">blendercreator.cpp:98</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">qint32</span> <span class="n">REND</span> <span style="color: #aa2211">=</span> <span class="n">isLittleEndian</span> <span style="color: #aa2211">?</span> <span style="color: #601200">1145980242</span> <span style="color: #74777d">/*python int.from_bytes(b'REND', byteorder='little')*/</span> <span style="color: #aa2211">:</span> <span style="color: #601200">1380273732</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">qint32</span> <span class="n">TEST</span> <span style="color: #aa2211">=</span> <span class="n">isLittleEndian</span> <span style="color: #aa2211">?</span> <span style="color: #601200">1414743380</span> <span style="color: #aa2211">:</span> <span style="color: #601200">1413829460</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">When you write these as hex, it becomes more obvious one is "REND" while the other is "DNER". Although ...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19696#inline-110465">View Inline</a><span style="color: #4b4d51; font-weight: bold;">blendercreator.cpp:101</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">bool</span> <span class="n">is64Bit</span> <span style="color: #aa2211">=</span> <span class="n">head</span><span class="p">[</span><span style="color: #601200">7</span><span class="p">]</span> <span style="color: #aa2211">==</span> <span style="color: #766510">'-'</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">fileBlockHeadSize</span> <span style="color: #aa2211">=</span> <span class="n">is64Bit</span> <span style="color: #aa2211">?</span> <span style="color: #601200">24</span> <span style="color: #aa2211">:</span> <span style="color: #601200">20</span><span class="p">;</span> <span style="color: #74777d">// sum(1 through 6)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">remainingHeader</span> <span style="color: #aa2211">=</span> <span class="n">fileBlockHeadSize</span> <span style="color: #aa2211">-</span> <span style="color: #601200">8</span><span class="p">;</span> <span style="color: #74777d">// sum(3 through 5)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Does this mean 'size of header fields 1 to 5'?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19696#inline-110464">View Inline</a><span style="color: #4b4d51; font-weight: bold;">blendercreator.cpp:105</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">while</span> <span class="p">(</span><span style="color: #304a96">true</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">blendStream</span> <span style="color: #aa2211">>></span> <span class="n">code</span> <span style="color: #aa2211">>></span> <span class="n">length</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">code</span> <span style="color: #aa2211">==</span> <span class="n">REND</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">... you can use <tt style="background: #ebebeb; font-size: 13px;">readRawData(data, 4)</tt> here and just compare with 'REND'.</p>
<p style="padding: 0; margin: 8px;">Or even always read the whole header, saving you the <tt style="background: #ebebeb; font-size: 13px;">skipRawData(remainingHeader)</tt>, and gets rid of <tt style="background: #ebebeb; font-size: 13px;">remainingHeader</tt>.</p>
<p style="padding: 0; margin: 8px;">Actually, using <tt style="background: #ebebeb; font-size: 13px;">operator>></tt> on raw data, i.e. anything not written using QDataStream is dangerous. There is <strong>no</strong> guarantee an int is serialized as just 4 bytes.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R320 KIO Extras</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19696">https://phabricator.kde.org/D19696</a></div></div><br /><div><strong>To: </strong>chinmoyr, Frameworks, bruns<br /><strong>Cc: </strong>bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov<br /></div>