<table><tr><td style="">jpalecek added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19514">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19514#inline-108987">View Inline</a><span style="color: #4b4d51; font-weight: bold;">avahi-publicservice_p.h:42</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">PublicServicePrivate</span><span class="p">(</span><span class="n">PublicService</span> <span style="color: #aa2211">*</span><span class="n">parent</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">name</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">type</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">domain</span><span class="p">,</span> <span style="color: #aa4000">unsigned</span> <span style="color: #aa4000">int</span> <span class="n">port</span><span class="p">)</span> <span style="color: #aa2211">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">QObject</span><span class="p">(),</span> <span class="n">ServiceBasePrivate</span><span class="p">(</span><span class="n">name</span><span class="p">,</span> <span class="n">type</span><span class="p">,</span> <span class="n">domain</span><span class="p">,</span> <span class="n">QString</span><span class="p">(),</span> <span class="n">port</span><span class="p">),</span> <span class="n">m_published</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">m_running</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">m_group</span><span class="p">(</span><span class="n">nullptr</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QObject</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">parent</span></span><span class="p">),</span> <span class="n">ServiceBasePrivate</span><span class="p">(</span><span class="n">name</span><span class="p">,</span> <span class="n">type</span><span class="p">,</span> <span class="n">domain</span><span class="p">,</span> <span class="n">QString</span><span class="p">(),</span> <span class="n">port</span><span class="p">),</span> <span class="n">m_published</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">m_running</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">m_group</span><span class="p">(</span><span class="n">nullptr</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">m_server</span><span class="p">(</span><span class="n">nullptr</span><span class="p">),</span> <span class="n">m_collision</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">m_parent</span><span class="p">(</span><span class="n">parent</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Initialize the QObject with the parent object to ensure deleting the Private object. In this case, the <tt style="background: #ebebeb; font-size: 13px;">PublicService</tt> object simply doesn't do it in its destructor AFAIK</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19514#inline-108989">View Inline</a><span style="color: #4b4d51; font-weight: bold;">avahi_listener.cpp:28</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_connection</span> <span style="color: #aa2211">=</span> <span class="n">QObject</span><span style="color: #aa2211">::</span><span class="n">connect</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">AvahiDisconnectHandler</span><span style="color: #aa2211">::</span><span class="n">instance</span><span class="p">(),</span> <span style="color: #aa2211">&</span><span class="n">AvahiDisconnectHandler</span><span style="color: #aa2211">::</span><span class="n">avahiDisconnected</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                    <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">]()</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">m_connection</tt> is needed to manually manage the connection, because <tt style="background: #ebebeb; font-size: 13px;">AvahiListener</tt> is not a <tt style="background: #ebebeb; font-size: 13px;">QObject</tt>. It is inherited by <tt style="background: #ebebeb; font-size: 13px;">QObject</tt>s, but relying on that (and casting) would need that the <tt style="background: #ebebeb; font-size: 13px;">QObject</tt> is initialized first which would be brittle. OTOH saving the connection handle seems hassle-free.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R272 KDNSSD</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19514">https://phabricator.kde.org/D19514</a></div></div><br /><div><strong>To: </strong>jpalecek, sitter<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>