<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18263">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18263#inline-108738">View Inline</a><span style="color: #4b4d51; font-weight: bold;">copyjob.cpp:344</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">destStr</span> <span style="color: #aa2211">=</span> <span class="n">KStringHandler</span><span style="color: #aa2211">::</span><span class="n">csqueeze</span><span class="p">(</span><span class="n">m_dest</span><span class="p">.</span><span class="n">toDisplayString</span><span class="p">(</span><span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">PreferLocalFile</span><span class="p">),</span> <span style="color: #601200">100</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">m_description</span> <span style="color: #aa2211">=</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"%1 %2 to %3"</span><span class="p">,</span> <span class="n">modeStr</span><span class="p">,</span> <span class="n">itemStr</span><span class="p">,</span> <span class="n">destStr</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">translators won't know what to do with this word puzzle. Better do</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">const QString str = m_mode == CopyJob::Copy ? i18n("Copying %1 to %2") : i18n("Moving %1 to %2");</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18263#inline-108739">View Inline</a><span style="color: #4b4d51; font-weight: bold;">job.cpp:123</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">static</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">s_<span class="bright">t</span>itle</span> <span style="color: #aa2211">=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"@title job"</span><span class="p">,</span> <span style="color: #766510">"Moving"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">static</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">s_<span class="bright">defaultT</span>itle</span> <span style="color: #aa2211">=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"@title job"</span><span class="p">,</span> <span style="color: #766510">"Moving"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">static</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">s_title</span> <span style="color: #aa2211">=</span> <span class="n">jobTitle</span><span class="p">(</span><span class="n">job</span><span class="p">,</span> <span class="n">s_defaultTitle</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">static</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">s_source</span> <span style="color: #aa2211">=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"The source of a file operation"</span><span class="p">,</span> <span style="color: #766510">"Source"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can't make this static, otherwise the very first job will determine what all subsequent jobs will get in s_title.</p>

<p style="padding: 0; margin: 8px;">And then remove the s_ prefix, of course.</p>

<p style="padding: 0; margin: 8px;">(*3)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18263">https://phabricator.kde.org/D18263</a></div></div><br /><div><strong>To: </strong>chinmoyr, dfaure, broulik<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>