<table><tr><td style="">astippich added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19109">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D19109#414968" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D19109#414968</a>, <a href="https://phabricator.kde.org/p/bruns/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@bruns</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D19109#414758" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D19109#414758</a>, <a href="https://phabricator.kde.org/p/astippich/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@astippich</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>A few general remarks:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">I really do not like that there are two lists of supported mimetypes now which have to be kept in sync</li>
</ul></div>
</blockquote>
<p>I think this is trivial enough. Also this is covered by the unit test.</p></div>
</blockquote>
<p>My fear is that it is easily forgotten, but I did not see the autotest. Still, do you think it is feasible to generate the mimetype stringlist from the JSON data to remove the duplication?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">Do we really need versioning per mimetype? IMHO it is sufficient to have a version number per extractor. From my experience, fixing an extractor usually impacts all its supported mimetypes, and rarily affects only one mimetype.</li>
</ul></blockquote>
<p>Past experience tells otherwise. There have been feature extensions and bugfixes for specific mimetypes, just look at your own commits</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">"fix ape disc number extraction"</li>
<li class="remarkup-list-item">"implement more tags for asf metadata"</li>
<li class="remarkup-list-item">...
<br /><br />
I want to reduce reindexing as much as possible.</li>
</ul></blockquote>
<p>And I can give you examples where this was not the case :). This is also only the case because TagLibExtractor was stupidly written (which <a href="https://phabricator.kde.org/D18826" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D18826</a> fixes). The other extractors do not have that many special codepath.<br />
Well, I find it cumbersome to implement this fine-grained control, but otherwise people will probably yell because of high cpu usage...<br />
At least, I would like to group duplicated mimetypes such as audio/wav and audio/x-wav, but that is not possible with JSON, is it?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Also, this makes the list hard to maintain, also regarding file types which have multiple mime types, e.g. audio/wav and audio/x-wav</pre></div>
<ul class="remarkup-list">
<li class="remarkup-list-item">Do we need an x.y version? I think a single integer is enough or what do you have in mind?</li>
</ul></blockquote>
<p>Changes only affecting failed files are minor versions, changes affecting already indexed files (i.e. support for new properties) get a new major version.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">I prefer to directly construct the qvariantmap in the extractors, and re-use the mimetype list which is already available.</li>
</ul></blockquote>
<p>Requires changing the plugin interface. Does not allow to query extractor properties without fully loading the plugin (which is expensive). Read <a href="https://vizzzion.org/blog/2013/08/" class="remarkup-link" target="_blank" rel="noreferrer">https://vizzzion.org/blog/2013/08/</a> "K_PLUGIN_FACTORY_WITH_JSON or where is the metadata?"</p></blockquote>
<p>Thanks.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19109">https://phabricator.kde.org/D19109</a></div></div><br /><div><strong>To: </strong>bruns, Baloo, Frameworks, ngraham, astippich, poboiko<br /><strong>Cc: </strong>kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>