<table><tr><td style="">bruns added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14661">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14661#410848" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D14661#410848</a>, <a href="https://phabricator.kde.org/p/volkov/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@volkov</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I guess that there is a short period of time when UDisks daemon is in inconsistent state, i.e. org.freedesktop.UDisks2.Filesystem interface is removed for CD-ROM device, but the device's properties still have Optical=true.<br />
Adding "updateBackend(udi);" before "emit deviceAdded(udi);" gives Udisks time to become consistent.</p></div>
</blockquote>
<p>Its not UDisks which is inconsistent, but the representation in Solid. It has a lot of issues:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">properties are not per interface in Solid, but per device. This is plain wrong (e.g. the partition and the filesystem '/dev/sda5' may have different size, but Solid merges their "Size" property).</li>
<li class="remarkup-list-item">Solid does not listen properly to the propertiesChanged event, but insists on polling in a number of places.</li>
<li class="remarkup-list-item">DBus messages are handled in different places (e.g. the interfaces signals, handled in both DeviceManager and the Device), leading to inconsistent state.</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R245 Solid</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14661">https://phabricator.kde.org/D14661</a></div></div><br /><div><strong>To: </strong>bruns, Frameworks, broulik, ngraham, apol<br /><strong>Cc: </strong>volkov, apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>