<table><tr><td style="">knauss added a comment.
</td></tr></table><br /><div><div><p>I'm not a expert in abi-complience-checker, so we need to find out together...</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/T3689#175022" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T3689#175022</a>, <a href="https://phabricator.kde.org/p/danders/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@danders</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"></div>
</blockquote>
<p>The ABI error started with build 4:<br />
<a href="https://build.kde.org/job/Calligra/job/kdiagram/job/kf5-qt5%20SUSEQt5.10/4/" class="remarkup-link" target="_blank" rel="noreferrer">https://build.kde.org/job/Calligra/job/kdiagram/job/kf5-qt5%20SUSEQt5.10/4/</a></p>
<p>but yes I can't see why the symbols are changed. Maybe the Qt version was switched in between. But from the error type it sounds like, that acc do not get the needed information of the underlying structure of QSet/QPair and can't garantee that this structure will be the same in future.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Afaics these lines have not been changed since last release.</p></blockquote>
<p>Well we don't have a released version with ABI, so we just check them against <a href="https://phabricator.kde.org/R478:a470d77be5a33529a95eb89243ddfaef6ee27ee7" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">a470d77be5a33529a95eb89243ddfaef6ee27ee7</a>. This will change if the next version is released.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Also it does not complain about similar use in calligra (although not *exactly* the same, calligra uses other datatypes)</p></blockquote>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Can anybody shed any light on this?</p></blockquote>
<p>well you can dig more into it by getting the abi dumps:<br />
<a href="https://build-artifacts.kde.org/production/ABIReference/" class="remarkup-link" target="_blank" rel="noreferrer">https://build-artifacts.kde.org/production/ABIReference/</a></p>
<p>after you downloaded two of the dumps you can check them again locally:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">abi-compliance-checker -l KGrantt --old <old.dump> --new <new.dump></pre></div>
<p>than you can look to all outputs yourself.</p>
<p>The abidumps look different:</p>
<p>for <a href="https://phabricator.kde.org/R478:a470d77be5a33529a95eb89243ddfaef6ee27ee7" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">a470d77be5a33529a95eb89243ddfaef6ee27ee7</a>:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">'90987' => {
'Algn' => 1,
'Header' => 'qpair.h',
'Line' => '49',
'Memb' => {
'0' => {
'algn' => 1,
'name' => 'first',
'type' => '11416'
},
'1' => {
'algn' => 1,
'name' => 'second',
'type' => '11416'
}
},
'Name' => 'QPair<struct QDateTime, struct QDateTime>',
'TParam' => {
'0' => {
'name' => 'struct QDateTime'
},
'1' => {
'name' => 'struct QDateTime'
}
},
'Type' => 'Struct'
},</pre></div>
<p>and for <a href="https://phabricator.kde.org/R478:f7f9ca1a7a8bfd550022ca4aafe3bb2985a1bee4" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">f7f9ca1a7a8bfd550022ca4aafe3bb2985a1bee4</a></p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">'90223' => {
'Algn' => 1,
'Header' => 'qpair.h',
'Line' => '49',
'Name' => 'QPair<struct QDateTime, struct QDateTime>',
'TParam' => {
'0' => {
'name' => 'struct QDateTime'
},
'1' => {
'name' => 'struct QDateTime'
}
},
'Type' => 'Struct'
},</pre></div>
<p>so yeah somehow it does not get as much information out of qpair.h as before.</p></div></div><br /><div><strong>TASK DETAIL</strong><div><a href="https://phabricator.kde.org/T3689">https://phabricator.kde.org/T3689</a></div></div><br /><div><strong>To: </strong>knauss<br /><strong>Cc: </strong>danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez<br /></div>