<table><tr><td style="">poboiko added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18664">View Revision</a></tr></table><br /><div><div><p>Nice! I like it, it's definitely much better than <tt style="background: #ebebeb; font-size: 13px;">Q_ASSERT_X</tt> macros that are just silently ignored in non-debug builds.</p>
<p>Have some nitpicks though:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Are we actually sure this is gonna fix all those crashes? Otherwise I would suggest using CCBUG instead of BUG inside the commit message.</li>
<li class="remarkup-list-item">Looks like this patch is composed of two parts - introducing new logging category and and improving error handling. It would be also nice to split those into two separate patches.</li>
<li class="remarkup-list-item">For now, logging is the only way to know if there's something bad going on. In that case I would suggest to at least increase severity of those messages - it would increase chances users will notice it. For example, use <tt style="background: #ebebeb; font-size: 13px;">qCCritical</tt> (but this would also require additional check for okayish/non-critical return codes, such as <tt style="background: #ebebeb; font-size: 13px;">MDB_NOTFOUND</tt>)</li>
<li class="remarkup-list-item">There are a lot of redundant <tt style="background: #ebebeb; font-size: 13px;">Q_ASSERT_X</tt> left, which could be removed. I suggest just <tt style="background: #ebebeb; font-size: 13px;">grep</tt>'ing over the code to catch'em all. I've started marking them here, but then I gave up - too many of them.</li>
<li class="remarkup-list-item">There are also several unchecked return codes as well, such as inside <tt style="background: #ebebeb; font-size: 13px;">*DB::size()</tt> calls. Those can also be found by <tt style="background: #ebebeb; font-size: 13px;">grep</tt>'ing over <tt style="background: #ebebeb; font-size: 13px;">Q_ASSERT_X</tt>.</li>
</ol></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18664#inline-103779">View Inline</a><span style="color: #4b4d51; font-weight: bold;">documentdatadb.cpp:142</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">Q_ASSERT_X</span><span class="p">(</span><span class="n">rc</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #766510">"DocumentDataDB::toTestMap"</span><span class="p">,</span> <span class="n">mdb_strerror</span><span class="p">(</span><span class="n">rc</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is not needed now, I guess</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18664#inline-103780">View Inline</a><span style="color: #4b4d51; font-weight: bold;">documentdb.cpp:144</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">MDB_stat</span> <span class="n">stat</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">int</span> <span class="n">rc</span> <span style="color: #aa2211">=</span> <span class="n">mdb_stat</span><span class="p">(</span><span class="n">m_txn</span><span class="p">,</span> <span class="n">m_dbi</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">stat</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">Q_ASSERT_X</span><span class="p">(</span><span class="n">rc</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #766510">"DocumentDB::size"</span><span class="p">,</span> <span class="n">mdb_strerror</span><span class="p">(</span><span class="n">rc</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This can also return something weird.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18664#inline-103778">View Inline</a><span style="color: #4b4d51; font-weight: bold;">postingdb.cpp:132</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">while</span> <span class="p">(</span><span class="n">rc</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">!=</span></span><span class="bright"> </span><span class="n"><span class="bright">MDB_NOTFOUND</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">while</span> <span class="p">(</span><span class="n">rc</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">Q_ASSERT_X</span><span class="p">(</span><span class="n">rc</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #766510">"PostingDB::fetchTermsStartingWith"</span><span class="p">,</span> <span class="n">mdb_strerror</span><span class="p">(</span><span class="n">rc</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This assert is not necessary here then?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18664">https://phabricator.kde.org/D18664</a></div></div><br /><div><strong>To: </strong>valeriymalov, Baloo, bruns, poboiko<br /><strong>Cc: </strong>ngraham, bruns, kde-frameworks-devel, Baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams<br /></div>