<table><tr><td style="">rjvbb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18380">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">I don't see the squeezed text when using Breeze and Noto Sans. Am I missing something?</pre></div></blockquote>
<p>No, I don't think so. This must correspond to the 2nd pair of images I attached.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">I kind of hope so, because I predict that if we ship with text that gets squeezed at various sizes, we'll totally get bug reports about it. :-)</pre></div></blockquote>
<p>No, this is mostly a font-specific thing; Noto Sans apparently doesn't stretch (nor squeeze) at typical UI sizes.<br />
And do you know of examples where this widget does NOT use the generic text font for the directory list? IOW, what are the chances that a single user can get instances of this widget where the font doesn't stretch and other instances where the font does stretch (because of being at another size or family)? Would they even notice?</p>
<p>I kind of agree with the principle of not complicating things overly, but I also kind of like the effect I created here. Who could we add to this review to get some more opinions?</p>
<p>I have a little font tinker app at github:RJVB/fontweightissue-qt5 (and a plasma-integration patch that adds support for alternative "kdeglobals" configurations at <a href="https://github.com/RJVB/macstrop/blob/master/Linux/kf5/kf5-plasma-integration/files/patch-support-alt-config.diff" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/RJVB/macstrop/blob/master/Linux/kf5/kf5-plasma-integration/files/patch-support-alt-config.diff</a> ;) )</p>
<p>FWIW, there's also a possibility to reduce letter spacing which can help here, but there the margin for error is a lot smaller.</p></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18380">https://phabricator.kde.org/D18380</a></div></div><br /><div><strong>To: </strong>rjvbb, ngraham<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>