<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10446">View Revision</a></tr></table><br /><div><div><p>Two more small comments from my side, otherwise looks cool :) Thanks for the perseverance!</p>
<p>I can't approve it because the review is on my name ^_^</p>
<p>Maybe <a href="https://phabricator.kde.org/p/apol/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@apol</a> can give it the ship it?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10446#inline-99688">View Inline</a><span style="color: #4b4d51; font-weight: bold;">klanguagenametest.cpp:80</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do you think it makes sense adding this?</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">void testNoString()
{
// Qt doesn't have za support so no string at all
QCOMPARE(KLanguageName::nameForCode("za"), QString());
}</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10446#inline-99539">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sitter</span> wrote in <span style="color: #4b4d51; font-weight: bold;">klanguagename.cpp:30</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Do you mean both being <strong>a</strong> code or both being <strong>the</strong> code?</p>
<h2 class="remarkup-header">a code</h2>
<p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">parts.at(0)</tt> is the code of the current locale. The only way I found to get the 639 code from qlocale is by splitting name <a href="http://doc.qt.io/qt-5/qlocale.html#name" class="remarkup-link" target="_blank" rel="noreferrer">http://doc.qt.io/qt-5/qlocale.html#name</a></p>
<p style="padding: 0; margin: 8px;">Perhaps a comment is needed to explain this?</p>
<h2 class="remarkup-header">the code</h2>
<p style="padding: 0; margin: 8px;">Both params being the variable <tt style="background: #ebebeb; font-size: 13px;">code</tt> wouldn't be right I think. The documentation for <tt style="background: #ebebeb; font-size: 13px;">nameForCode</tt> says it will ideally give you the localized name of code in the system language.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">LANGUAGE=en nameForCode('en') => 'English'
LANGUAGE=fr nameForCode('en') => 'anglaise'</pre></div>
<p style="padding: 0; margin: 8px;">which internally is</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">nameForCodeInLocale('en', 'en')
nameForCodeInLocale('en', 'fr')</pre></div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Argggg, ignore me i was reading the code wrong. Sorry for the noise</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10446#inline-99687">View Inline</a><span style="color: #4b4d51; font-weight: bold;">klanguagename.h:34</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> *</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * @since 5.44</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> *</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Needs to be 5.55 i think</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R265 KConfigWidgets</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10446">https://phabricator.kde.org/D10446</a></div></div><br /><div><strong>To: </strong>aacid<br /><strong>Cc: </strong>hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns<br /></div>