<table><tr><td style="">achauvel added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17371">View Revision</a></tr></table><br /><div><div><p>I think it’s better than what I proposed (without knowing about yours) in <a href="https://phabricator.kde.org/D17727" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D17727</a>.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17371#inline-97500">View Inline</a><span style="color: #4b4d51; font-weight: bold;">krun.cpp:1421-1431</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// If a default browser isn't set in kdeglobals, fall back to mimeapps.list</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_externalBrowser</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span class="n">Ptr</span> <span class="n">profile</span> <span style="color: #aa2211">=</span> <span class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span class="n">openConfig</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"mimeapps.list"</span><span class="p">),</span> <span class="n">KConfig</span><span style="color: #aa2211">::</span><span class="n">NoGlobals</span><span class="p">,</span> <span class="n">QStandardPaths</span><span style="color: #aa2211">::</span><span class="n">GenericConfigLocation</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KConfigGroup</span> <span style="color: #004012">defaultApps</span><span class="p">(</span><span class="n">profile</span><span class="p">,</span> <span style="color: #766510">"Default Applications"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">m_externalBrowser</span> <span style="color: #aa2211">=</span> <span class="n">defaultApps</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"x-scheme-handler/https"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I personally would have gone for</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">// If a default browser isn't set in kdeglobals, fall back to mimeapps.list
if (!d->m_externalBrowser.isEmpty()) {
return;
}
KSharedConfig::Ptr profile = KSharedConfig::openConfig(QStringLiteral("mimeapps.list"), KConfig::NoGlobals, QStandardPaths::GenericConfigLocation);
KConfigGroup defaultApps(profile, "Default Applications");
d->m_externalBrowser = defaultApps.readEntry("x-scheme-handler/https");
if (d->m_externalBrowser.isEmpty()) {
d->m_externalBrowser = defaultApps.readEntry("x-scheme-handler/http");
}</pre></div>
<p style="padding: 0; margin: 8px;">to avoid too much nesting.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17371">https://phabricator.kde.org/D17371</a></div></div><br /><div><strong>To: </strong>ngraham, Frameworks, broulik, cfeck, elvisangelaccio<br /><strong>Cc: </strong>achauvel, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>