<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17651">View Revision</a></tr></table><br /><div><div><p>Thanks!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17651#inline-97025">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kconfigtest.cpp:1726</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">file</span><span class="p">.</span><span class="n">open</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qWarning</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span class="n">file</span><span class="p">.</span><span class="n">fileName</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">KConfig</span> <span style="color: #004012">config</span><span class="p">(</span><span class="n">file</span><span class="p">.</span><span class="n">fileName</span><span class="p">(),</span> <span class="n">KConfig</span><span style="color: #aa2211">::</span><span class="n">SimpleConfig</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Remove (or at least degrade to qDebug, this is not a warning)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17651#inline-97026">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kconfigtest.cpp:1739</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">readFile</span><span class="p">.</span><span class="n">open</span><span class="p">(</span><span class="n">QFile</span><span style="color: #aa2211">::</span><span class="n">ReadOnly</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#ifndef Q_OS_WIN</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">readFile</span><span class="p">.</span><span class="n">readAll</span><span class="p">(),</span> <span class="n">QByteArrayLiteral</span><span class="p">(</span><span style="color: #766510">"[General]</span><span style="color: #bb6622">\n</span><span style="color: #766510">Utf8=</span><span style="color: #bb6622">\\</span><span style="color: #766510">x00</span><span style="color: #bb6622">\\</span><span style="color: #766510">x01</span><span style="color: #bb6622">\\</span><span style="color: #766510">x02</span><span style="color: #bb6622">\\</span><span style="color: #766510">x03</span><span style="color: #bb6622">\\</span><span style="color: #766510">x04</span><span style="color: #bb6622">\\</span><span style="color: #766510">x05</span><span style="color: #bb6622">\\</span><span style="color: #766510">x06</span><span style="color: #bb6622">\\</span><span style="color: #766510">x07</span><span style="color: #bb6622">\\</span><span style="color: #766510">x08</span><span style="color: #bb6622">\\</span><span style="color: #766510">t</span><span style="color: #bb6622">\\</span><span style="color: #766510">n</span><span style="color: #bb6622">\\</span><span style="color: #766510">x0b</span><span style="color: #bb6622">\\</span><span style="color: #766510">x0c</span><span style="color: #bb6622">\\</span><span style="color: #766510">r</span><span style="color: #bb6622">\\</span><span style="color: #766510">x0e</span><span style="color: #bb6622">\\</span><span style="color: #766510">x0f</span><span style="color: #bb6622">\\</span><span style="color: #766510">x10</span><span style="color: #bb6622">\\</span><span style="color: #766510">x11</span><span style="color: #bb6622">\\</span><span style="color: #766510">x12</span><span style="color: #bb6622">\\</span><span style="color: #766510">x13</span><span style="color: #bb6622">\\</span><span style="color: #766510">x14</span><span style="color: #bb6622">\\</span><span style="color: #766510">x15</span><span style="color: #bb6622">\\</span><span style="color: #766510">x16</span><span style="color: #bb6622">\\</span><span style="color: #766510">x17</span><span style="color: #bb6622">\\</span><span style="color: #766510">x18</span><span style="color: #bb6622">\\</span><span style="color: #766510">x19</span><span style="color: #bb6622">\\</span><span style="color: #766510">x1a</span><span style="color: #bb6622">\\</span><span style="color: #766510">x1b</span><span style="color: #bb6622">\\</span><span style="color: #766510">x1c</span><span style="color: #bb6622">\\</span><span style="color: #766510">x1d</span><span style="color: #bb6622">\\</span><span style="color: #766510">x1e</span><span style="color: #bb6622">\\</span><span style="color: #766510">x1f !</span><span style="color: #bb6622">\"</span><span style="color: #766510">#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[</span><span style="color: #bb6622">\\\\</span><span style="color: #766510">]^_`abcdefghijklmnopqrstuvwxyz{|}~</span><span style="color: #bb6622">\\</span><span style="color: #766510">x7f</span><span style="color: #bb6622">\\</span><span style="color: #766510">x80</span><span style="color: #bb6622">\\</span><span style="color: #766510">x81</span><span style="color: #bb6622">\\</span><span style="color: #766510">x82</span><span style="color: #bb6622">\\</span><span style="color: #766510">x83</span><span style="color: #bb6622">\\</span><span style="color: #766510">x84</span><span style="color: #bb6622">\\</span><span style="color: #766510">x85</span><span style="color: #bb6622">\\</span><span style="color: #766510">x86</span><span style="color: #bb6622">\\</span><span style="color: #766510">x87</span><span style="color: #bb6622">\\</span><span style="color: #766510">x88</span><span style="color: #bb6622">\\</span><span style="color: #766510">x89</span><span style="color: #bb6622">\\</span><span style="color: #766510">x8a</span><span style="color: #bb6622">\\</span><span style="color: #766510">x8b</span><span style="color: #bb6622">\\</span><span style="color: #766510">x8c</span><span style="color: #bb6622">\\</span><span style="color: #766510">x8d</span><span style="color: #bb6622">\\</span><span style="color: #766510">x8e</span><span style="color: #bb6622">\\</span><span style="color: #766510">x8f</span><span style="color: #bb6622">\\</span><span style="color: #766510">x90</span><span style="color: #bb6622">\\</span><span style="color: #766510">x91</span><span style="color: #bb6622">\\</span><span style="color: #766510">x92</span><span style="color: #bb6622">\\</span><span style="color: #766510">x93</span><span style="color: #bb6622">\\</span><span style="color: #766510">x94</span><span style="color: #bb6622">\\</span><span style="color: #766510">x95</span><span style="color: #bb6622">\\</span><span style="color: #766510">x96</span><span style="color: #bb6622">\\</span><span style="color: #766510">x97</span><span style="color: #bb6622">\\</span><span style="color: #766510">x98</span><span style="color: #bb6622">\\</span><span style="color: #766510">x99</span><span style="color: #bb6622">\\</span><span style="color: #766510">x9a</span><span style="color: #bb6622">\\</span><span style="color: #766510">x9b</span><span style="color: #bb6622">\\</span><span style="color: #766510">x9c</span><span style="color: #bb6622">\\</span><span style="color: #766510">x9d</span><span style="color: #bb6622">\\</span><span style="color: #766510">x9e</span><span style="color: #bb6622">\\</span><span style="color: #766510">x9f</span><span style="color: #bb6622">\\</span><span style="color: #766510">xa0</span><span style="color: #bb6622">\\</span><span style="color: #766510">xa1</span><span style="color: #bb6622">\\</span><span style="color: #766510">xa2</span><span style="color: #bb6622">\\</span><span style="color: #766510">xa3</span><span style="color: #bb6622">\\</span><span style="color: #766510">xa4</span><span style="color: #bb6622">\\</span><span style="color: #766510">xa5</span><span style="color: #bb6622">\\</span><span style="color: #766510">xa6</span><span style="color: #bb6622">\\</span><span style="color: #766510">xa7</span><span style="color: #bb6622">\\</span><span style="color: #766510">xa8</span><span style="color: #bb6622">\\</span><span style="color: #766510">xa9</span><span style="color: #bb6622">\\</span><span style="color: #766510">xaa</span><span style="color: #bb6622">\\</span><span style="color: #766510">xab</span><span style="color: #bb6622">\\</span><span style="color: #766510">xac</span><span style="color: #bb6622">\\</span><span style="color: #766510">xad</span><span style="color: #bb6622">\\</span><span style="color: #766510">xae</span><span style="color: #bb6622">\\</span><span style="color: #766510">xaf</span><span style="color: #bb6622">\\</span><span style="color: #766510">xb0</span><span style="color: #bb6622">\\</span><span style="color: #766510">xb1</span><span style="color: #bb6622">\\</span><span style="color: #766510">xb2</span><span style="color: #bb6622">\\</span><span style="color: #766510">xb3</span><span style="color: #bb6622">\\</span><span style="color: #766510">xb4</span><span style="color: #bb6622">\\</span><span style="color: #766510">xb5</span><span style="color: #bb6622">\\</span><span style="color: #766510">xb6</span><span style="color: #bb6622">\\</span><span style="color: #766510">xb7</span><span style="color: #bb6622">\\</span><span style="color: #766510">xb8</span><span style="color: #bb6622">\\</span><span style="color: #766510">xb9</span><span style="color: #bb6622">\\</span><span style="color: #766510">xba</span><span style="color: #bb6622">\\</span><span style="color: #766510">xbb</span><span style="color: #bb6622">\\</span><span style="color: #766510">xbc</span><span style="color: #bb6622">\\</span><span style="color: #766510">xbd</span><span style="color: #bb6622">\\</span><span style="color: #766510">xbe</span><span style="color: #bb6622">\\</span><span style="color: #766510">xbf</span><span style="color: #bb6622">\\</span><span style="color: #766510">xc0</span><span style="color: #bb6622">\\</span><span style="color: #766510">xc1</span><span style="color: #bb6622">\\</span><span style="color: #766510">xc2</span><span style="color: #bb6622">\\</span><span style="color: #766510">xc3</span><span style="color: #bb6622">\\</span><span style="color: #766510">xc4</span><span style="color: #bb6622">\\</span><span style="color: #766510">xc5</span><span style="color: #bb6622">\\</span><span style="color: #766510">xc6</span><span style="color: #bb6622">\\</span><span style="color: #766510">xc7</span><span style="color: #bb6622">\\</span><span style="color: #766510">xc8</span><span style="color: #bb6622">\\</span><span style="color: #766510">xc9</span><span style="color: #bb6622">\\</span><span style="color: #766510">xca</span><span style="color: #bb6622">\\</span><span style="color: #766510">xcb</span><span style="color: #bb6622">\\</span><span style="color: #766510">xcc</span><span style="color: #bb6622">\\</span><span style="color: #766510">xcd</span><span style="color: #bb6622">\\</span><span style="color: #766510">xce</span><span style="color: #bb6622">\\</span><span style="color: #766510">xcf</span><span style="color: #bb6622">\\</span><span style="color: #766510">xd0</span><span style="color: #bb6622">\\</span><span style="color: #766510">xd1</span><span style="color: #bb6622">\\</span><span style="color: #766510">xd2</span><span style="color: #bb6622">\\</span><span style="color: #766510">xd3</span><span style="color: #bb6622">\\</span><span style="color: #766510">xd4</span><span style="color: #bb6622">\\</span><span style="color: #766510">xd5</span><span style="color: #bb6622">\\</span><span style="color: #766510">xd6</span><span style="color: #bb6622">\\</span><span style="color: #766510">xd7</span><span style="color: #bb6622">\\</span><span style="color: #766510">xd8</span><span style="color: #bb6622">\\</span><span style="color: #766510">xd9</span><span style="color: #bb6622">\\</span><span style="color: #766510">xda</span><span style="color: #bb6622">\\</span><span style="color: #766510">xdb</span><span style="color: #bb6622">\\</span><span style="color: #766510">xdc</span><span style="color: #bb6622">\\</span><span style="color: #766510">xdd</span><span style="color: #bb6622">\\</span><span style="color: #766510">xde</span><span style="color: #bb6622">\\</span><span style="color: #766510">xdf</span><span style="color: #bb6622">\\</span><span style="color: #766510">xe0</span><span style="color: #bb6622">\\</span><span style="color: #766510">xe1</span><span style="color: #bb6622">\\</span><span style="color: #766510">xe2</span><span style="color: #bb6622">\\</span><span style="color: #766510">xe3</span><span style="color: #bb6622">\\</span><span style="color: #766510">xe4</span><span style="color: #bb6622">\\</span><span style="color: #766510">xe5</span><span style="color: #bb6622">\\</span><span style="color: #766510">xe6</span><span style="color: #bb6622">\\</span><span style="color: #766510">xe7</span><span style="color: #bb6622">\\</span><span style="color: #766510">xe8</span><span style="color: #bb6622">\\</span><span style="color: #766510">xe9</span><span style="color: #bb6622">\\</span><span style="color: #766510">xea</span><span style="color: #bb6622">\\</span><span style="color: #766510">xeb</span><span style="color: #bb6622">\\</span><span style="color: #766510">xec</span><span style="color: #bb6622">\\</span><span style="color: #766510">xed</span><span style="color: #bb6622">\\</span><span style="color: #766510">xee</span><span style="color: #bb6622">\\</span><span style="color: #766510">xef</span><span style="color: #bb6622">\\</span><span style="color: #766510">xf0</span><span style="color: #bb6622">\\</span><span style="color: #766510">xf1</span><span style="color: #bb6622">\\</span><span style="color: #766510">xf2</span><span style="color: #bb6622">\\</span><span style="color: #766510">xf3</span><span style="color: #bb6622">\\</span><span style="color: #766510">xf4</span><span style="color: #bb6622">\\</span><span style="color: #766510">xf5</span><span style="color: #bb6622">\\</span><span style="color: #766510">xf6</span><span style="color: #bb6622">\\</span><span style="color: #766510">xf7</span><span style="color: #bb6622">\\</span><span style="color: #766510">xf8</span><span style="color: #bb6622">\\</span><span style="color: #766510">xf9</span><span style="color: #bb6622">\\</span><span style="color: #766510">xfa</span><span style="color: #bb6622">\\</span><span style="color: #766510">xfb</span><span style="color: #bb6622">\\</span><span style="color: #766510">xfc</span><span style="color: #bb6622">\\</span><span style="color: #766510">xfd</span><span style="color: #bb6622">\\</span><span style="color: #766510">xfe</span><span style="color: #bb6622">\\</span><span style="color: #766510">xff</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The expected value without trailing newline could have been put into a constant, shared between Windows and non-Windows code paths, to avoid all this duplication ;-)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R237 KConfig</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17651">https://phabricator.kde.org/D17651</a></div></div><br /><div><strong>To: </strong>vandenoever, dfaure, arichardson, apol<br /><strong>Cc: </strong>apol, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>