<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17619">View Revision</a></tr></table><br /><div><div><p>Please change the summary to something more descriptive. A bug number is pretty opaque in itself.</p>
<p>The patch itself looks good.</p>
<p>I also don't understand "kdirmodeltest tests this already". It passes for me, without this change.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17619">https://phabricator.kde.org/D17619</a></div></div><br /><div><strong>To: </strong>jtamate, dfaure, Frameworks<br /><strong>Cc: </strong>elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>