<table><tr><td style="">elvisangelaccio added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17270">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17270#inline-96719">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kurlnavigator.h:297</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">bool</span> <span style="color: #004012">isInsideCompressedPath</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span style="color: #aa2211">&</span><span class="n">path</span><span class="p">)</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'd make this function <tt style="background: #ebebeb; font-size: 13px;">static</tt>, since it doesn't depend on the status of a specific <tt style="background: #ebebeb; font-size: 13px;">KUrlNavigator</tt> instance.</p>
<p style="padding: 0; margin: 8px;">To do so, <tt style="background: #ebebeb; font-size: 13px;">isCompressedPath()</tt> needs to become a (static) free function.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17270#inline-96715">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kurlnavigatorbutton.cpp:416</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span class="n">kurlnavigator</span> <span style="color: #aa2211">=</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">KUrlNavigator</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">parent</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">kurlnavigator</span><span style="color: #aa2211">-></span><span class="n">isInsideCompressedPath</span><span class="p">(</span><span class="n">kurlnavigator</span><span style="color: #aa2211">-></span><span class="n">locationUrl</span><span class="p">()))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// We are in an archive, check whether the subdir we have to list is part of the archive</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What if the parent is not a <tt style="background: #ebebeb; font-size: 13px;">KUrlNavigator</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17270#inline-94838">View Inline</a><span style="color: #4b4d51; font-weight: bold;">thsurrel</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kurlnavigatorbutton.cpp:414</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">What would be the clean way to expose this function ? I wouldn't like to duplicate the code.<br />
And btw, the "if ((m_url.scheme() == QLatin1String("tar")) || (m_url.scheme() == QLatin1String("zip")))" condition was taken from KUrlNavigator::setLocationUrl, so there must be a bugfix to be made there as well with the 'krarc' case gregormi reports.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">What would be the clean way to expose this function ? I wouldn't like to duplicate the code.</p></blockquote>
<p style="padding: 0; margin: 8px;">Sorry for the late reply. One way could be a public static function, either in <tt style="background: #ebebeb; font-size: 13px;">KUrlNavigator</tt> or <tt style="background: #ebebeb; font-size: 13px;">KUrlNavigatorButton</tt>.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17270">https://phabricator.kde.org/D17270</a></div></div><br /><div><strong>To: </strong>thsurrel, Frameworks<br /><strong>Cc: </strong>elvisangelaccio, gregormi, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>