<table><tr><td style="">dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17545">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17545#inline-96752">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jobtest.cpp:1004</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QSignalSpy</span> <span style="color: #004012">spy</span><span class="p">(</span><span class="n">job</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">KJob</span><span style="color: #aa2211">::</span><span class="n">error</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">setUiDelegate</span><span class="p">(</span><span style="color: #aa4000">nullptr</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">At runtime, Qt says:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QSignalSpy: Not a valid signal: ''</pre></div>
<p style="padding: 0; margin: 8px;">Indeed this is the getter, not a signal. <tt style="background: #ebebeb; font-size: 13px;">result()</tt> is the signal, but you don't really need to connect to it anyway.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17545#inline-96753">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jobtest.cpp:1007</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QVERIFY</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">job</span><span style="color: #aa2211">-></span><span class="n">exec</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">job</span><span style="color: #aa2211">-></span><span class="n">error</span><span class="p">(),</span> <span class="p">(</span><span style="color: #aa4000">int</span><span class="p">)</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">ERR_CANNOT_WRITE</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">spy</span><span class="p">.</span><span class="n">count</span><span class="p">(),</span> <span style="color: #601200">1</span><span class="p">);</span> <span style="color: #74777d">// one error should be emitted by the move job</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">FAIL! : JobTest::moveDirectoryToInaccessibleFilesystem() Compared values are not the same</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Actual (job->error()) : 115
Expected ((int)KIO::ERR_CANNOT_WRITE): 129</pre></div>
<p style="padding: 0; margin: 8px;">115 is ERR_ACCESS_DENIED, see <tt style="background: #ebebeb; font-size: 13px;">grep -w 15 src/core/global.h </tt></p>
<p style="padding: 0; margin: 8px;">I think that's because you went too far (due to copy/pasting). The dest dir shouldn't be inaccessible, it should only be readonly.</p>
<p style="padding: 0; margin: 8px;">Also you forgot the cleanup at the end of the method, which breaks running the test multiple times.</p>
<p style="padding: 0; margin: 8px;">OK, even with all this the test doesn't pass.<br />
Stepping into statNextSrc, I see that it goes into startRenameJob on line 846 so it doesn't get into your new code which is further down.<br />
That's because the src and dest are on the same partition, so a simple rename is enough.</p>
<p style="padding: 0; margin: 8px;">Changing dst_dir to use otherTmpDir() ... ok, the error code changes, now it's 137, i.e. ERR_COULD_NOT_MKDIR :-)<br />
This requires further investigation...</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17545">https://phabricator.kde.org/D17545</a></div></div><br /><div><strong>To: </strong>shubham, Frameworks, dfaure<br /><strong>Cc: </strong>davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns<br /></div>