<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17545">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17545#inline-96324">View Inline</a><span style="color: #4b4d51; font-weight: bold;">copyjob.cpp:862</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// if the destination file system doesn't support writing, do not stat</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QFileInfo</span> <span class="n">destInfo</span><span class="p">(</span><span class="n">m_currentDestURL</span><span class="p">.</span><span class="n">toString</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">((</span><span class="n">m_mode</span> <span style="color: #aa2211">==</span> <span class="n">CopyJob</span><span style="color: #aa2211">::</span><span class="n">Copy</span> <span style="color: #aa2211">||</span> <span class="n">m_mode</span> <span style="color: #aa2211">==</span> <span class="n">CopyJob</span><span style="color: #aa2211">::</span><span class="n">Move</span><span class="p">)</span> <span style="color: #aa2211">&&</span> <span class="p">(</span><span class="n">destInfo</span><span class="p">.</span><span class="n">isDir</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">destInfo</span><span class="p">.</span><span class="n">isWritable</span><span class="p">()))</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Wrong mix of URLs and paths. How can this ever work? QFileInfo takes local paths, and you're giving it a full URL?</p>
<p style="padding: 0; margin: 8px;">All this should be inside if (m_currentDestURL.isLocalFile()) and use m_currentDestURL.toLocalFile() as the path to give to QFileInfo.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17545#inline-96326">View Inline</a><span style="color: #4b4d51; font-weight: bold;">copyjob.cpp:863</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QFileInfo</span> <span class="n">destInfo</span><span class="p">(</span><span class="n">m_currentDestURL</span><span class="p">.</span><span class="n">toString</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">((</span><span class="n">m_mode</span> <span style="color: #aa2211">==</span> <span class="n">CopyJob</span><span style="color: #aa2211">::</span><span class="n">Copy</span> <span style="color: #aa2211">||</span> <span class="n">m_mode</span> <span style="color: #aa2211">==</span> <span class="n">CopyJob</span><span style="color: #aa2211">::</span><span class="n">Move</span><span class="p">)</span> <span style="color: #aa2211">&&</span> <span class="p">(</span><span class="n">destInfo</span><span class="p">.</span><span class="n">isDir</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">destInfo</span><span class="p">.</span><span class="n">isWritable</span><span class="p">()))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QPointer</span><span style="color: #aa2211"><</span><span class="n">CopyJob</span><span style="color: #aa2211">></span> <span class="n">that</span> <span style="color: #aa2211">=</span> <span class="n">q</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why the "copy or move" test? The only alternative is creating a symlink, which also requires being able to write, no?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17545#inline-96325">View Inline</a><span style="color: #4b4d51; font-weight: bold;">copyjob.cpp:865</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QPointer</span><span style="color: #aa2211"><</span><span class="n">CopyJob</span><span style="color: #aa2211">></span> <span class="n">that</span> <span style="color: #aa2211">=</span> <span class="n">q</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">warning</span><span class="p">(</span><span class="n">q</span><span class="p">,</span> <span class="n">buildErrorString</span><span class="p">(</span><span class="n">ERR_CYCLIC_COPY</span><span class="p">,</span> <span class="n">m_currentDestURL</span><span class="p">.</span><span class="n">toDisplayString</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">that</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This used to be an error, now it gets degraded to a warning. This means applications performing the copy will think it actually worked, only the user got (maybe) a warning....</p>
<p style="padding: 0; margin: 8px;">I think this should be an error.</p>
<p style="padding: 0; margin: 8px;">And there should be a unittest for it. JobTest::copyFolderWithUnaccessibleSubfolder shows how to make a folder non-writable (and still be able to clean it up at the end). A similar test should be added where the destination is the one that is unaccessible (or just unwritable).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17545#inline-96273">View Inline</a><span style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span style="color: #4b4d51; font-weight: bold;">copyjob.cpp:864</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Not sure <tt style="background: #ebebeb; font-size: 13px;">ERR_CYCLIC_COPY</tt> is the correct error for this?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It doesn't sound like it, no. This should rather be ERR_CANNOT_WRITE.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17545">https://phabricator.kde.org/D17545</a></div></div><br /><div><strong>To: </strong>shubham, Frameworks, dfaure<br /><strong>Cc: </strong>ngraham, broulik, kde-frameworks-devel, michaelh, bruns<br /></div>