<table><tr><td style="">pranavgade added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17381">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17381#inline-95237">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jgrulich</span> wrote in <span style="color: #4b4d51; font-weight: bold;">macsecsettingtest.cpp:29</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">This required version is not true, please verify it properly, I'm not going to do it every time :).</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I tried to get the version from here: <br />
<a href="https://phabricator.kde.org/F6459587" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6459587: Screenshot from 2018-12-06 22-13-34.png</a></p>
<p style="padding: 0; margin: 8px;">Is that incorrect?<br />
If so, from where do I check the version?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17381#inline-95238">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jgrulich</span> wrote in <span style="color: #4b4d51; font-weight: bold;">macsecsetting.h:58</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Can be turned into an enum.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">From where can I get the possible values? Because I cannot find them here: <a href="https://developer.gnome.org/NetworkManager/stable/settings-macsec.html" class="remarkup-link" target="_blank" rel="noreferrer">https://developer.gnome.org/NetworkManager/stable/settings-macsec.html</a></p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17381">https://phabricator.kde.org/D17381</a></div></div><br /><div><strong>To: </strong>pranavgade, jgrulich<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>