<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16671">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16671#inline-95029">View Inline</a><span style="color: #4b4d51; font-weight: bold;">embeddedimagedata.cpp:134</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">TagLib</span><span style="color: #aa2211">::</span><span class="n">FLAC</span><span style="color: #aa2211">::</span><span class="n">File</span> <span class="n">flacFile</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">stream</span><span class="p">,</span> <span class="n">TagLib</span><span style="color: #aa2211">::</span><span class="n">ID3v2</span><span style="color: #aa2211">::</span><span class="n">FrameFactory</span><span style="color: #aa2211">::</span><span class="n">instance</span><span class="p">(),</span> <span style="color: #304a96">true</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">TagLib</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">List</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span class="n"><span class="bright">TagLib</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">FLAC</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="n">Picture<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*></span></span><span class="bright"> </span><span class="n"><span class="bright">lstPic</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n">flacFile</span><span class="p">.</span><span class="n">pictureList</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">return</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">getFrontCoverFromFlac</span>Picture<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">flacFile</span><span class="p">.</span><span class="n">pictureList</span><span class="p">(<span class="bright">)</span>);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Does Taglib signal an error when it fails to parse the file? Or is calling pictureList() always safe?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16671#inline-95024">View Inline</a><span style="color: #4b4d51; font-weight: bold;">embeddedimagedata.cpp:148</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">TagLib</span><span style="color: #aa2211">::</span><span class="n">Ogg</span><span style="color: #aa2211">::</span><span class="n">Opus</span><span style="color: #aa2211">::</span><span class="n">File</span> <span class="n">opusFile</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">stream</span><span class="p">,</span> <span style="color: #304a96">true</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"> </span><span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">opusFile</span><span class="p">.</span><span class="n">tag<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">!</span></span><span class="bright"></span><span class="n"><span class="bright">opusFile</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">tag</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">isEmpty</span></span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"> </span><span class="n"><span class="bright">lstPic</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n">opusFile</span><span class="p">.</span><span class="n">tag</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">pictureList</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">opusFile</span><span class="p">.</span><span class="n">tag</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">return</span></span><span class="bright"> </span><span class="n"><span class="bright">getFrontCoverFromFlacPicture</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">opusFile</span><span class="p">.</span><span class="n">tag</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">pictureList</span><span class="p">(<span class="bright">)</span>);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not sure if this is an issue, but the old code only called <tt style="background: #ebebeb; font-size: 13px;">tag()->pictureList()</tt> after <tt style="background: #ebebeb; font-size: 13px;">!tag()->isEmpty()</tt> - is this safe without?<br />
Dito for oggFile above.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16671#inline-91516">View Inline</a><span style="color: #4b4d51; font-weight: bold;">astippich</span> wrote in <span style="color: #4b4d51; font-weight: bold;">embeddedimagedata.cpp:204</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">The code also works if only the picture data is there without the name.<br />
I could return an empty QByteArray if dataPosition == -1 and pictureData.size == 0.<br />
Do you prefer if I do that separately?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is it safe to call find on an empty ByteVector - most likely yes ...<br />
Then return QByteArray on dataPosition == -1, so it is obvious the error case is handled, and keep the rest as is.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16671">https://phabricator.kde.org/D16671</a></div></div><br /><div><strong>To: </strong>astippich, mgallien, bruns<br /><strong>Cc: </strong>kde-frameworks-devel, Baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>