<table><tr><td style="">jgrulich added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17185">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17185#inline-93855">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:31</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> wirelesssecuritysettingtest
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> iptunnelsettingtest
</div><div style="padding: 0 8px; margin: 0 4px; ">)
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you please add the test in alphabetic order?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17185#inline-93859">View Inline</a><span style="color: #4b4d51; font-weight: bold;">iptunnelsettingtest.cpp:79</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">map</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="n">NMQT_SETTING_IP_TUNNEL_CONFIG_MODE</span><span class="p">),</span> <span class="n">mode</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">map</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="n">NMQT_SETTING_IP_TUNNEL_CONFIG_PATH_MTU_DISCOVERY</span><span class="p">),</span> <span class="n">pathMtuDiscovery</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use NetworkManager defines, do not define your own new defines, there is no reason for that.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17185#inline-93856">View Inline</a><span style="color: #4b4d51; font-weight: bold;">iptunnelsettingtest.h:2</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/*</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> Copyright 2016 Jan Grulich <jgrulich@redhat.com></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You should add yourself here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17185#inline-93860">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:229</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> WirelessSetting
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> IpTunnelSetting
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please add this in alphabetic order.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17185#inline-93862">View Inline</a><span style="color: #4b4d51; font-weight: bold;">connectionsettings.cpp:195</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">addSetting</span><span class="p">(</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">Ptr</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">Ipv6Setting</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">addSetting</span><span class="p">(</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">Ptr</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">IpTunnelSetting</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">break</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">IpTunnel setting is not part of Tun connection, it should be completely separated connection type.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17185#inline-93868">View Inline</a><span style="color: #4b4d51; font-weight: bold;">iptunnelsetting.cpp:27</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">IpTunnelSettingPrivate</span><span style="color: #aa2211">::</span><span class="n">IpTunnelSettingPrivate</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa2211">:</span> <span class="n">name</span><span class="p">(</span><span class="n">NM_SETTING_IP_TUNNEL_SETTING_NAME</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">,</span> <span class="n">mode</span><span class="p">(</span><span class="n">IpTunnelSetting</span><span style="color: #aa2211">::</span><span class="n">DefaultMode</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Coding style, missing indentation. This applies also for lines below.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17185#inline-93858">View Inline</a><span style="color: #4b4d51; font-weight: bold;">iptunnelsetting.h:29</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#define NMQT_SETTING_IP_TUNNEL_CONFIG_ENCAPSULATION_LIMIT NM_SETTING_IP_TUNNEL_ENCAPSULATION_LIMIT</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#define NMQT_SETTING_IP_TUNNEL_CONFIG_FLAGS "flags"</span><span style="color: #74777d">//NM_SETTING_IP_TUNNEL_FLAGS</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There is no reason to create your own defines, use just those NM_SETTING_IP_TUNNEL_PROPERTY_NAME.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17185#inline-93863">View Inline</a><span style="color: #4b4d51; font-weight: bold;">iptunnelsetting.h:57</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">typedef</span> <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">Ptr</span><span style="color: #aa2211">></span> <span class="n">List</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">enum</span> <span class="n">Mode</span> <span class="p">{</span> <span class="n">DefaultMode</span><span class="p">,</span> <span class="n">Ipip</span><span class="p">,</span> <span class="n">Gre</span> <span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There are other modes, they are just not documented in the documentation, but can be found in the source code.</p>
<p style="padding: 0; margin: 8px;">See:<br />
typedef enum {<br />
NM_IP_TUNNEL_MODE_UNKNOWN = 0,<br />
NM_IP_TUNNEL_MODE_IPIP = 1,<br />
NM_IP_TUNNEL_MODE_GRE = 2,<br />
NM_IP_TUNNEL_MODE_SIT = 3,<br />
NM_IP_TUNNEL_MODE_ISATAP = 4,<br />
NM_IP_TUNNEL_MODE_VTI = 5,<br />
NM_IP_TUNNEL_MODE_IP6IP6 = 6,<br />
NM_IP_TUNNEL_MODE_IPIP6 = 7,<br />
NM_IP_TUNNEL_MODE_IP6GRE = 8,<br />
NM_IP_TUNNEL_MODE_VTI6 = 9,<br />
} NMIPTunnelMode;</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17185#inline-93865">View Inline</a><span style="color: #4b4d51; font-weight: bold;">iptunnelsetting.h:74</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">setFlags</span><span class="p">(</span><span class="n">quint32</span> <span class="n">flags</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">quint32</span> <span style="color: #004012">flags</span><span class="p">()</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe turn this into QFlags?</p>
<p style="padding: 0; margin: 8px;">See:<br />
typedef enum { /*< flags, prefix=NM_IP_TUNNEL_FLAG >*/<br />
NM_IP_TUNNEL_FLAG_NONE = 0x0,<br />
NM_IP_TUNNEL_FLAG_IP6_IGN_ENCAP_LIMIT = 0x1,<br />
NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_TCLASS = 0x2,<br />
NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_FLOWLABEL = 0x4,<br />
NM_IP_TUNNEL_FLAG_IP6_MIP6_DEV = 0x8,<br />
NM_IP_TUNNEL_FLAG_IP6_RCV_DSCP_COPY = 0x10,<br />
NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_FWMARK = 0x20,<br />
} NMIPTunnelFlags;</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R282 NetworkManagerQt</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17185">https://phabricator.kde.org/D17185</a></div></div><br /><div><strong>To: </strong>pranavgade, jgrulich<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>