<table><tr><td style="">apol marked an inline comment as done.<br />apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17052">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17052#inline-92827">View Inline</a><span style="color: #4b4d51; font-weight: bold;">zzag</span> wrote in <span style="color: #4b4d51; font-weight: bold;">framesvg.cpp:569</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Do we really need to pass a shared pointer? Wouldn't it better to just pass a raw pointer? We won't do any ownership-related stuff anyway.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It doesn't really make a difference because it's a const& so it doesn't construct a new object (i.e. it doesn't refcount +1 and -1 upon leave).<br />
On the other hand this makes it possible to pass the object we store without calling anything which I see as an advantage.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17052#inline-92821">View Inline</a><span style="color: #4b4d51; font-weight: bold;">zzag</span> wrote in <span style="color: #4b4d51; font-weight: bold;">framesvg.cpp:618</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Just newFd->cacheId.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can't do, QWeakPointer doesn't overload operator-></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17052">https://phabricator.kde.org/D17052</a></div></div><br /><div><strong>To: </strong>apol, Plasma, Frameworks<br /><strong>Cc: </strong>mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>