<table><tr><td style="">ngraham accepted this revision.<br />ngraham added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16772">View Revision</a></tr></table><br /><div><div><p>Makes sense to me. Now that I see them all together, I agree that /_ is a bit better. It seems much better for the folder, and at least no worse (and probably a bit better) for the disk.</p>
<p>Any other VDG comments, or should we land this?</p>
<p>BTW, <a href="https://phabricator.kde.org/p/ndavis/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ndavis</a>, you're doing so much good work that I would recommend you apply for a Developer account so you can land your own patches. You can read about that here: <a href="https://community.kde.org/Infrastructure/Get_a_Developer_Account" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Infrastructure/Get_a_Developer_Account</a></p>
<p>BTW, once this goes in, I'll submit a KIO patch to use the new icon for the current <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Root</span></span></span> Places Panel item. If we end up not removing it after all, we might as well use the nice new icon! :)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R266 Breeze Icons</div></div></div><br /><div><strong>BRANCH</strong><div><div>folder-root (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16772">https://phabricator.kde.org/D16772</a></div></div><br /><div><strong>To: </strong>ndavis, VDG, ngraham<br /><strong>Cc: </strong>ngraham, VDG, kde-frameworks-devel, michaelh, bruns<br /></div>