<table><tr><td style="">romangg added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16708">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16708#inline-90926">View Inline</a><span style="color: #4b4d51; font-weight: bold;">zzag</span> wrote in <span style="color: #4b4d51; font-weight: bold;">textinput_interface.cpp:67</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">purpose_? or just keep previous name (wlPurpose)?</p>
<p style="padding: 0; margin: 8px;"><a href="https://techbase.kde.org/Policies/Frameworks_Coding_Style#Variable_Declarations" class="remarkup-link" target="_blank" rel="noreferrer">https://techbase.kde.org/Policies/Frameworks_Coding_Style#Variable_Declarations</a></p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">wlPurpose is also an abbreviation. ;)</p>
<p style="padding: 0; margin: 8px;">And in the header file it is named <tt style="background: #ebebeb; font-size: 13px;">purpose</tt>. Makes more sense to me to have the name without abbreviation in the API. I'll rename the function variable though.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16708">https://phabricator.kde.org/D16708</a></div></div><br /><div><strong>To: </strong>romangg, KWin, Frameworks<br /><strong>Cc: </strong>zzag, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>