<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15645">View Revision</a></tr></table><br /><div><div><p>Doesn't build for me:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">[ 51%] Building CXX object tests/CMakeFiles/kcodecactiontest.dir/kcodecactiontest.cpp.o
/home/dev/repos/kconfigwidgets/tests/kcolorschemedemo.cpp: In constructor ‘KColorSchemeDemo::KColorSchemeDemo()’:
/home/dev/repos/kconfigwidgets/tests/kcolorschemedemo.cpp:46:34: error: ‘class KColorSchemeManager’ has no member named ‘createSchemeSelectionMenuWithDefault’; did you mean ‘createSchemeSelectionMenuWithDefaultEntry’?
button->setMenu(manager->createSchemeSelectionMenuWithDefault({}, {}, {}, button)->menu());
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
createSchemeSelectionMenuWithDefaultEntry
[ 53%] Building CXX object tests/CMakeFiles/kcodecactiontest.dir/kcodecactiontest_autogen/mocs_compilation.cpp.o</pre></div></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15645#inline-89606">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcolorschemedemo.cpp:46</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">button</span><span style="color: #aa2211">-></span><span class="n">setIcon</span><span class="p">(</span><span class="n">QIcon</span><span style="color: #aa2211">::</span><span class="n">fromTheme</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"fill-color"</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">button</span><span style="color: #aa2211">-></span><span class="n">setMenu</span><span class="p">(</span><span class="n">manager</span><span style="color: #aa2211">-></span><span class="n">createSchemeSelectionMenu<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Oxygen"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>,</span> <span class="n">button</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">menu</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">button</span><span style="color: #aa2211">-></span><span class="n">setMenu</span><span class="p">(</span><span class="n">manager</span><span style="color: #aa2211">-></span><span class="n">createSchemeSelectionMenu<span class="bright">WithDefault</span></span><span class="bright"></span><span class="p"><span class="bright">({},</span></span><span class="bright"> </span><span class="p"><span class="bright">{},</span></span><span class="bright"> </span><span class="p"><span class="bright">{}</span>,</span> <span class="n">button</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">menu</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Needs to be <tt style="background: #ebebeb; font-size: 13px;">createSchemeSelectionMenuWithDefaultEntry</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R265 KConfigWidgets</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15645">https://phabricator.kde.org/D15645</a></div></div><br /><div><strong>To: </strong>amhndu, Frameworks, broulik, cfeck, elvisangelaccio, ngraham<br /><strong>Cc: </strong>ngraham, broulik, kde-frameworks-devel, michaelh, bruns<br /></div>